Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Espresso's VirtualPoly, MLE and SumCheck #8

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

arnaucube
Copy link
Collaborator

Port Espresso/hyperplonk's virtualpolynomial, multilinearpolynomial and sum_check utils from
https://github.com/EspressoSystems/hyperplonk/tree/main Each file contains the reference to the original file.

Porting it into a subdirectory src/utils/espresso, to have it self-contained. In future iterations we might replace part of it but we can keep focusing on the folding schemes part for now.

@arnaucube arnaucube force-pushed the port/utils-espresso branch 2 times, most recently from 015fd43 to f1319ab Compare August 25, 2023 10:53
@arnaucube arnaucube changed the title Port Espresso/hyperplonk's utils Port Espresso/hyperplonk's utils (VirtualPoly, multilinear, and SumChec) Aug 25, 2023
@arnaucube arnaucube changed the title Port Espresso/hyperplonk's utils (VirtualPoly, multilinear, and SumChec) Port Espresso/hyperplonk's utils (VirtualPoly, multilinear, and SumCheck) Aug 25, 2023
@arnaucube arnaucube changed the title Port Espresso/hyperplonk's utils (VirtualPoly, multilinear, and SumCheck) Port Espresso's VirtualPoly, MLE and SumCheck Aug 25, 2023
@arnaucube arnaucube requested a review from han0110 August 25, 2023 10:55
@arnaucube arnaucube force-pushed the port/utils-espresso branch 3 times, most recently from fe8af34 to 9565feb Compare August 25, 2023 15:50
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a nitpick.

Cargo.toml Outdated Show resolved Hide resolved
Port Espresso/hyperplonk's `virtualpolynomial`, `multilinearpolynomial`
and `sum_check` utils from
https://github.com/EspressoSystems/hyperplonk/tree/main
Each file contains the reference to the original file.

Porting it into a subdirectory `src/utils/espresso`, to have it
self-contained. In future iterations we might replace part of it but we
can keep focusing on the folding schemes part for now.
@arnaucube arnaucube added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit b4a0b50 Aug 29, 2023
3 checks passed
@arnaucube arnaucube deleted the port/utils-espresso branch November 7, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants