Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following bugs in
casm super
(#289):casm super --scelnames scel1 --get-transf-mat
crashescasm super --scelnames scel1 --get-transf-mat --unitcell SCEL1_1_1_1_0_0_0
always returns the identity matrix--confignames
and--scelnames
options were only supposed to take one argument if--duper
was not passed. This check was failing, so I fixed it, which also fixed some other--duper
checks.I also reformatted the
--help
output to match query.cc.Two more comments:
casm super --scelnames scel --transf-mat T
orcasm super --duper
write to the supercell database, which I think should be optional. I can try to implement this if it sounds like a good idea.casm super --duper
,casm super --get-transf-mat
, andcasm super --transf-mat
all have different behavior. But, I think fixing this should be part of standardizing the app interfaces in general.