Record form calculated fields #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs some refactoring as eslint doesn't like where the code currently lives.
This gets around the issue that eslint was complaining about as the react hook is now at the top level, and we pass a closure into it.
awensaunders
force-pushed
the
record-form-calculated-fields
branch
from
838108c to
74bf634
Compare
pnabutovsky
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements calculated fields at the record level, as opposed to just at the subform level.
I've put the logic in the record-form component because it's necessary to recalculate whenever any of the relevant fields on the record change, even if the calculated field component is not currently rendered (perhaps as it's on a different form section).