Merged in r2-2655-api-disabling-notifications (pull request #6601)

R2-2655 - API Disabling send push and email notifications

app/models/assign.rb

@@ -7,6 +7,8 @@
 class Assign < Transition
   MAX_BULK_RECORDS = 100
 
+  attr_accessor :from_bulk_export
+
   def perform
     return if transitioned_to_user.nil?
 
@@ -25,4 +27,8 @@ def consent_given?
   def notified_statuses
     [Transition::STATUS_DONE]
   end
+
+  def should_notify?
+    !from_bulk_export && super
+  end
 end

app/models/transition.rb

@@ -92,11 +92,15 @@ def notified_statuses
   end
 
   def notify
-    return unless notified_statuses.include?(status)
+    return unless should_notify?
 
     TransitionNotifyJob.perform_later(id)
   end
 
+  def should_notify?
+    notified_statuses.include?(status)
+  end
+
   def index_record
     Sunspot.index(record) if record
   end

app/services/bulk_assign_service.rb

@@ -34,7 +34,8 @@ def create_assignment(record)
       record:,
       transitioned_to: @args[:transitioned_to],
       transitioned_by: @transitioned_by.user_name,
-      notes: @args[:notes]
+      notes: @args[:notes],
+      from_bulk_export: true
     )
   end
 

spec/jobs/bulk_assign_records_spec.rb

@@ -32,6 +32,10 @@
                    disclosure_other_orgs: true, module_id: PrimeroModule::CP)
   end
 
+  before :each do
+    BulkAssignService.any_instance.stub(:search_results).and_return([child])
+  end
+
   describe 'perform_later' do
     before do
       ActiveJob::Base.queue_adapter = :test
@@ -53,6 +57,26 @@
     end
   end
 
+  describe 'when job is performed' do
+    let(:bulk_assign_params) do
+      {
+        transitioned_to: user2.user_name,
+        transitioned_by: user.user_name,
+        notes: 'this is a note',
+        filters: { short_id: [child.short_id] }
+      }
+    end
+
+    it 'should not enqueue a TransitionNotifyJob' do
+      ActiveJob::Base.queue_adapter = :test
+      BulkAssignRecordsJob.perform_now(Child, user, **bulk_assign_params)
+
+      expect(
+        ActiveJob::Base.queue_adapter.enqueued_jobs.select { |j| j[:job] == TransitionNotifyJob }.size
+      ).to eq(0)
+    end
+  end
+
   after :each do
     clean_data(User, Role, PrimeroModule, PrimeroProgram, Field, FormSection, UserGroup, Agency, Child, Transition)
   end

spec/models/assign_spec.rb

@@ -5,6 +5,8 @@
 require 'rails_helper'
 
 describe Assign do
+  include ActiveJob::TestHelper
+
   before do
     clean_data(User, Role, PrimeroModule, UserGroup, Agency, Transition, Incident, Child)
 
@@ -150,6 +152,28 @@
         end
       end
     end
+
+    describe '.notify' do
+      context 'when should_notify? is true' do
+        it 'should enqueue a TransitionNotifyJob' do
+          expect(
+            ActiveJob::Base.queue_adapter.enqueued_jobs.select { |j| j[:job] == TransitionNotifyJob }.size
+          ).to eq(1)
+        end
+      end
+      context 'when should_notify? is false' do
+        before do
+          clear_enqueued_jobs
+          Assign.create!(transitioned_by: 'user1', transitioned_to: 'user2', record: @case, from_bulk_export: true)
+        end
+
+        it 'should enqueue a TransitionNotifyJob' do
+          expect(
+            ActiveJob::Base.queue_adapter.enqueued_jobs.select { |j| j[:job] == TransitionNotifyJob }.size
+          ).to eq(0)
+        end
+      end
+    end
   end
 
   context 'and the user has permission within the user group' do

spec/services/bulk_assign_service_spec.rb

@@ -45,7 +45,8 @@
       {
         transitioned_to: user2.user_name,
         transitioned_by: user.user_name,
-        notes: 'this is a note'
+        notes: 'this is a note',
+        from_bulk_export: true
       }
     end