Bump the otel group with 4 updates #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust), [opentelemetry-otlp](https://github.com/open-telemetry/opentelemetry-rust), [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust) and [tracing-opentelemetry](https://github.com/tokio-rs/tracing-opentelemetry) to permit the latest version. Updates `opentelemetry` to 0.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.26.0...opentelemetry-0.27.0) Updates `opentelemetry-otlp` to 0.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-otlp-0.26.0...opentelemetry-otlp-0.27.0) Updates `opentelemetry_sdk` to 0.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry_sdk-0.26.0...opentelemetry_sdk-0.27.0) Updates `tracing-opentelemetry` to 0.28.0 - [Release notes](https://github.com/tokio-rs/tracing-opentelemetry/releases) - [Changelog](https://github.com/tokio-rs/tracing-opentelemetry/blob/v0.1.x/CHANGELOG.md) - [Commits](tokio-rs/tracing-opentelemetry@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production dependency-group: otel - dependency-name: opentelemetry-otlp dependency-type: direct:production dependency-group: otel - dependency-name: opentelemetry_sdk dependency-type: direct:production dependency-group: otel - dependency-name: tracing-opentelemetry dependency-type: direct:production dependency-group: otel ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
Updated following this migration guide: open-telemetry/opentelemetry-rust#2221 Delta between 0.26 and 0.27 here: open-telemetry/opentelemetry-rust@opentelemetry-otlp-0.26.0...opentelemetry-otlp-0.27.0 |
MaeIsBad
reviewed
Nov 28, 2024
src/telemetry.rs
Outdated
|
|
||
| set_tracer_provider(tracer_provider.clone()); | ||
|
|
||
| tracer_provider | ||
| .tracer_builder("prima-tracing") | ||
| let scope = InstrumentationScope::builder(env!("CARGO_PKG_NAME")) |
There was a problem hiding this comment.
Not sure if this is correct according to the spec
There was a problem hiding this comment.
Reverted to simply prima-tracing
| .build() | ||
| .build(); | ||
|
|
||
| tracer_provider.tracer_with_scope(scope) |
There was a problem hiding this comment.
Do we need to create a scope? I think that a scope is supposed to start at an entrypoint(eg. Http call). I think this will create a global scope, encompassing everything that happens to the application
There was a problem hiding this comment.
AFAIK this is how they ported it in their PR 🤷♂️
We may not need to do it at all, but I think this was a "problem" before too
MaeIsBad
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on opentelemetry, opentelemetry-otlp, opentelemetry_sdk and tracing-opentelemetry to permit the latest version.
Updates
opentelemetryto 0.27.0Release notes
Sourced from opentelemetry's releases.
Commits
ade08cbPrepare for v0.27.0 - update Metrics API and Log(bridge) API to RC, Metrics S...648710eMove Views under feature flag (#2298)47d5016Add PeriodicReaderWithOwnThread (#2292)b833118Renamelogs_level_enabledflag tospec_unstable_logs_enabled(#2291)0cc2cd5Add usage doc comment for AnyValue type (#2293)845cf21Move Temporality enum opentelemetry_sdk::metrics::data:: to opentelemetry_sdk...a707bb9Update code documentation for Metric instruments (#2281)c322a50Histogram implementation cleanup (#2283)540c6f1Few fixes to changelog for breaking changes (#2287)52f6d92Remove Counter/Add benchmark for delta temporality (#2285)Updates
opentelemetry-otlpto 0.27.0Release notes
Sourced from opentelemetry-otlp's releases.
Commits
ade08cbPrepare for v0.27.0 - update Metrics API and Log(bridge) API to RC, Metrics S...648710eMove Views under feature flag (#2298)47d5016Add PeriodicReaderWithOwnThread (#2292)b833118Renamelogs_level_enabledflag tospec_unstable_logs_enabled(#2291)0cc2cd5Add usage doc comment for AnyValue type (#2293)845cf21Move Temporality enum opentelemetry_sdk::metrics::data:: to opentelemetry_sdk...a707bb9Update code documentation for Metric instruments (#2281)c322a50Histogram implementation cleanup (#2283)540c6f1Few fixes to changelog for breaking changes (#2287)52f6d92Remove Counter/Add benchmark for delta temporality (#2285)Updates
opentelemetry_sdkto 0.27.0Release notes
Sourced from opentelemetry_sdk's releases.
Commits
ade08cbPrepare for v0.27.0 - update Metrics API and Log(bridge) API to RC, Metrics S...648710eMove Views under feature flag (#2298)47d5016Add PeriodicReaderWithOwnThread (#2292)b833118Renamelogs_level_enabledflag tospec_unstable_logs_enabled(#2291)0cc2cd5Add usage doc comment for AnyValue type (#2293)845cf21Move Temporality enum opentelemetry_sdk::metrics::data:: to opentelemetry_sdk...a707bb9Update code documentation for Metric instruments (#2281)c322a50Histogram implementation cleanup (#2283)540c6f1Few fixes to changelog for breaking changes (#2287)52f6d92Remove Counter/Add benchmark for delta temporality (#2285)Updates
tracing-opentelemetryto 0.28.0Release notes
Sourced from tracing-opentelemetry's releases.
Changelog
Sourced from tracing-opentelemetry's changelog.
... (truncated)
Commits
f6fc075chore: update msrv to 1.70.0c61c66achore: bump version to 0.28.0b698047chore: update opentelemetry dependencies to 0.27.095f9ab9Add level metadata to spans (#182)ab629c3adding support for setting the status of the span through SpanExt (#176)515fe00Reduce locking in Layer::on_closeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions