Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COOP-270: Porting code from original repo #4

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

EddieWhi
Copy link
Contributor

@EddieWhi EddieWhi commented Sep 28, 2023

Ported code from uk-pcw branch and fixed mix check issues.

Moved TODOs to readme to make credo happy (and me happy too).
Added missing docs
Fixed dialyzer catch on SignerMatchStrategy.match_signer_for_kid/2

Ported code from uk-pcw and fixed `mix check` issues.
@EddieWhi EddieWhi force-pushed the COOP-270/task/port-library-code branch from d92b43e to 3cbb2c8 Compare September 29, 2023 08:31
Copy link

@chriseyre2000 chriseyre2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

Copy link

@chriseyre2000 chriseyre2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@EddieWhi EddieWhi merged commit 80b7029 into master Sep 29, 2023
3 checks passed
@EddieWhi EddieWhi deleted the COOP-270/task/port-library-code branch September 29, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants