Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUWEN-1504]: avrogen: optional maps #6

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

cottinisimone
Copy link
Contributor

@cottinisimone cottinisimone commented Sep 9, 2024

https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PUWEN-1504

This is the easiest solution to fix this warning. I think we should remove this function here and let the team that uses this tool fix their test errors.

@cottinisimone cottinisimone requested a review from a team as a code owner September 9, 2024 12:00
@oxg558
Copy link
Contributor

oxg558 commented Sep 9, 2024

let the team that uses this tool fix their test errors

That would be us :D

We'll have to see how much work it will be, but I wouldn't want to merge and deploy this before we fix them, as that would mean we couldn't upgrade the library version (and get any other fixes) until we do that. I seem to remember last time we looked it was quite a big job, and we don't really have the bandwidth at the moment.

@cottinisimone
Copy link
Contributor Author

let the team that uses this tool fix their test errors

That would be us :D

We'll have to see how much work it will be, but I wouldn't want to merge and deploy this before we fix them, as that would mean we couldn't upgrade the library version (and get any other fixes) until we do that. I seem to remember last time we looked it was quite a big job, and we don't really have the bandwidth at the moment.

Ok, do you think that it might makes sense that we try to do that job for you?
I was wondering if this is just a matter of broken tests or it might affect production..?

@oxg558
Copy link
Contributor

oxg558 commented Sep 11, 2024

@cottinisimone I've done the work for pricing in the PR below (not sure you can view uk-pricing), and we just need to do the same again for dataland. It will affect the data pipelines so we're waiting on a response from the uk analysts before we merge anything.

https://github.com/primait/uk-pricing/pull/815

@cottinisimone
Copy link
Contributor Author

@cottinisimone I've done the work for pricing in the PR below (not sure you can view uk-pricing), and we just need to do the same again for dataland. It will affect the data pipelines so we're waiting on a response from the uk analysts before we merge anything.

https://github.com/primait/uk-pricing/pull/815

Nope, i cannot see it.

Thank you @oxg558 for your help :)

Copy link
Contributor

@oxg558 oxg558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have merged our patches so this should be OK for us now. Thanks for waiting!

@cottinisimone cottinisimone merged commit 8e23e7e into master Sep 17, 2024
3 checks passed
@cottinisimone cottinisimone deleted the PUWEN-1504/task/avrogen-optional-maps branch September 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants