Merge pull request #1 from Kenneth-Sills/kesills-fix-tests

Update Unit Tests for `@stylistic` Plugins
prettier · Sep 30, 2024 · c4651b1 · c4651b1
2 parents 278db1d + 1977134
commit c4651b1
Show file tree

Hide file tree

Showing 8 changed files with 71 additions and 8 deletions.
diff --git a/.changeset/purple-snakes-call.md b/.changeset/purple-snakes-call.md
@@ -0,0 +1,5 @@
+---
+"eslint-config-prettier": minor
+---
+
+add support for @stylistic formatting rules
diff --git a/.eslintrc.base.js b/.eslintrc.base.js
@@ -95,9 +95,25 @@ module.exports = {
       },
     },
     {
-      files: ["test-lint/{react,flowtype}.js"],
+      files: ["test-lint/{react,flowtype}.js", "test-lint/@stylistic__jsx.jsx"],
       parserOptions: { parser: "@babel/eslint-parser" },
     },
+    {
+      files: ["test-lint/@stylistic.js"],
+      extends: ["plugin:@stylistic/all-extends"],
+    },
+    {
+      files: ["test-lint/@stylistic__js.js"],
+      extends: ["plugin:@stylistic/js/all-extends"],
+    },
+    {
+      files: ["test-lint/@stylistic__jsx.jsx"],
+      extends: ["plugin:@stylistic/jsx/all-extends"],
+    },
+    {
+      files: ["test-lint/@stylistic__ts.ts"],
+      extends: ["plugin:@stylistic/ts/all-extends"],
+    },
   ],
   settings: {
     react: {

diff --git a/eslint.base.config.js b/eslint.base.config.js
@@ -89,9 +89,23 @@ module.exports = [
       ...vue.configs.recommended.rules,
     },
   },
-  ...eslintrcBase.overrides.map(({ parserOptions, ...override }) => ({
-    ...override,
-    languageOptions: { parser: require(parserOptions.parser) },
-  })),
+  ...eslintrcBase.overrides
+    .filter(({ parserOptions }) => parserOptions)
+    .map(({ parserOptions, ...override }) => ({
+      ...override,
+      languageOptions: { parser: require(parserOptions.parser) },
+    })),
   { files: ["test-lint/@stylistic.js"], ...stylistic.configs["all-flat"] },
+  {
+    files: ["test-lint/@stylistic__js.js"],
+    ...stylisticJs.configs["all-flat"],
+  },
+  {
+    files: ["test-lint/@stylistic__jsx.jsx"],
+    ...stylisticJsx.configs["all-flat"],
+  },
+  {
+    files: ["test-lint/@stylistic__ts.ts"],
+    ...stylisticTs.configs["all-flat"],
+  },
 ];
diff --git a/package.json b/package.json
@@ -20,8 +20,8 @@
     "prettier": "prettier --write .",
     "test:prettier": "prettier --check .",
     "test:eslint": "eslint .",
-    "test:lint-verify-fail": "eslint \"test-lint/*.{js,ts,vue}\" --config .eslintrc.base.js --format json",
-    "test:lint-verify-fail:flat": "eslint \"test-lint/*.{js,ts,vue}\" --config eslint.base.config.js --format json",
+    "test:lint-verify-fail": "eslint \"test-lint/*.{js,jsx,ts,vue}\" --config .eslintrc.base.js --format json",
+    "test:lint-verify-fail:flat": "eslint \"test-lint/*.{js,jsx,ts,vue}\" --config eslint.base.config.js --format json",
     "test:lint-rules": "eslint index.js --config test-config/.eslintrc.js --format json",
     "test:lint-rules:flat": "eslint index.js --config test-config/eslint.config.js --format json",
     "test:deprecated": "eslint-find-rules --deprecated index.js",

diff --git a/test-lint/@stylistic__js.js b/test-lint/@stylistic__js.js
@@ -0,0 +1,6 @@
+/* eslint-disable quotes,max-len,curly */
+"use strict";
+
+// Prettier wants a newline after the condition, but `eslint-config-google` does not.
+if (cart.items && cart.items[0] && cart.items[0].quantity === 0)
+  updateCart(cart);
diff --git a/test-lint/@stylistic__jsx.jsx b/test-lint/@stylistic__jsx.jsx
@@ -0,0 +1,8 @@
+/* eslint-disable quotes, react/jsx-max-props-per-line */
+"use strict";
+
+const React = require("react");
+
+// Prettier wants several attributes on the same line, but "plugin:react/all"
+// only allows one per line.
+module.exports = <div className id />;
diff --git a/test-lint/@stylistic__ts.ts b/test-lint/@stylistic__ts.ts
@@ -0,0 +1,6 @@
+/* eslint-disable quotes,max-len,curly,@typescript-eslint/indent */
+"use strict";
+
+// Prettier wants a newline after the condition, but `eslint-config-google` does not.
+if (cart.items && cart.items[0] && cart.items[0].quantity === 0)
+  updateCart(cart);
diff --git a/test/lint-verify-fail.test.js b/test/lint-verify-fail.test.js
@@ -52,7 +52,7 @@ describe("test-lint/ causes errors without eslint-config-prettier", () => {
   output.forEach((data) => {
     const name = path
       .basename(data.filePath)
-      .replace(/\.(?:js|ts)$|-file\.vue$/, "");
+      .replace(/\.(?:js|jsx|ts)$|-file\.vue$/, "");
     const ruleIds = data.messages.map((message) => message.ruleId);
 
     describe(name, () => {
@@ -70,6 +70,14 @@ describe("test-lint/ causes errors without eslint-config-prettier", () => {
               .filter((ruleId) => ruleId.includes("/"))
               .concat("no ruleId should not contain a slash")
           ).toEqual(["no ruleId should not contain a slash"]);
+        } else if (name.startsWith("@stylistic__")) {
+          const stylisticGroup = name.split("__")[1];
+          const rulePrefix = `@stylistic/${stylisticGroup}/`;
+          expect(
+            ruleIds
+              .filter((ruleId) => !ruleId.startsWith(rulePrefix))
+              .concat(`every ruleId should start with: ${rulePrefix}`)
+          ).toEqual([`every ruleId should start with: ${rulePrefix}`]);
         } else {
           expect(
             ruleIds