Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esmock from 2.3.8 to 2.4.1 #922

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 8, 2023

Bumps esmock from 2.3.8 to 2.4.1.

Release notes

Sourced from esmock's releases.

detect null and undefined loader-returned sources

Detects null AND undefined loader-returned source definitions

diff --git a/src/esmockLoader.js b/src/esmockLoader.js
index 69dedd4..e835ec3 100644
--- a/src/esmockLoader.js
+++ b/src/esmockLoader.js
@@ -145,7 +145,8 @@ const load = async (url, context, nextLoad) => {
       if (!/^(commonjs|module)$/.test(nextLoadRes.format))
         return nextLoad(url, context)


 const source = nextLoadRes.source === null





 // nextLoadRes.source sometimes 'undefined' and other times 'null' :(



 const source = nextLoadRes.source === null || nextLoadRes.source === undefined
   ? String(await fs.readFile(new URL(url)))
   : String(nextLoadRes.source)
 const hbang = (source.match(hashbangRe) || [])[0] || ''


node v20.6 solutions

node v20.6 caused some issues. The primary issue was that the newest import.meta.resolve defined by node has significantly and suddenly changed. The newer import.meta.resolve is less useful and no longer supports the parent param as in the call import.meta.resolve(moduleId, parent),

Changelog

Sourced from esmock's changelog.

changelog

... (truncated)

Commits
  • 2fc016c Merge pull request #238 from iambumblehead/resolve-failing-cjs-import-mock-tests
  • 289cb62 replace regexp with more explicit test
  • b0c3280 use memoized regexps
  • c4f26a9 update link at changelog
  • 1fe29ea detect both undefined and null loader-returned sources
  • e3be36a update test fles
  • 221b37e Merge pull request #237 from iambumblehead/remove-import.meta.resolve
  • e11b6de update CHANGELOG and increment version
  • eac045a comment-out failing test
  • 0c3f18a restore test file to master state
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [esmock](https://github.com/iambumblehead/esmock) from 2.3.8 to 2.4.1.
- [Release notes](https://github.com/iambumblehead/esmock/releases)
- [Changelog](https://github.com/iambumblehead/esmock/blob/master/CHANGELOG.md)
- [Commits](iambumblehead/esmock@v2.3.8...v2.4.1)

---
updated-dependencies:
- dependency-name: esmock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 8, 2023
@Janther Janther merged commit 8bfa2a9 into main Sep 8, 2023
8 checks passed
@Janther Janther deleted the dependabot/npm_and_yarn/esmock-2.4.1 branch September 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant