only check version once #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janther
added
enhancement
Janther
added a commit
that referenced
this pull request
Oct 31, 2023
…o a constant checked at the loading of the module
|
If #941 is merged, this one should be ignored. |
Janther
added a commit
that referenced
this pull request
Nov 7, 2023
…tation (#941) * Proposal for avoiding separation between function definitions without an implementation * compatibility with Prettier 2 * refactor backward compatibility utils * moving isPrettier2 to the backwards compatibility module * reorganising the logic for clarity and to avoid having to check for extra lines added by mistake at the end * to avoid conflicts with #912 we changed isPrettier2 from a function to a constant checked at the loading of the module * Adding documentation * only check for leading comments
|
closing as this behaviour was in #941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPrettier2should be a constant, not a function.