Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert the dispatchEvent() result #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Invert the dispatchEvent() result #24

wants to merge 1 commit into from

Conversation

sgtpep
Copy link

@sgtpep sgtpep commented May 18, 2016

target.dispatchEvent() should return false if an event was prevented and false otherwise.

@sgtpep
Invert the dispatchEvent() result
c996be1 
target.dispatchEvent() should return false if an event was prevented and false otherwise.
stefanpenner
stefanpenner requested changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change requires corresponding tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgtpep @stefanpenner