Automatically find gpg-agent socket path #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script: - Starts gpg-agent with correct directory (testdata/gnupg) - Sets GNUPGHOME for other gnupg programs to find the right directory. - Runs go test, adding any arguments from the runtests.sh commandline.
If no GPG-agent socket path was given to Dial, try to find socket path by running the gpgconf program.
|
Hey Erik, Apologies for the late reply and thank you for your PR 👍 If this is indeed your first time writing Go, then you're off to a great start! I'd be happy to merge your PR, with the exception of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code that uses the gpgconf command to find the gpg-agent socket path. The old behaviour is kept, it's only if the call to agent.Dial has the empty string as filename argument that the code will try to find the socket automatically.
Tested on Ubuntu bionic.
Also made a few minor changes to the README, and made travis builds work even on forks. In addition, created a script for running the tests locally.
Please point out any go-related beginners mistakes, it's my first go code :-)