Added MaterialPropertyBlock scale/offset, NormalMap fix #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpetry
changed the title
…necessary emission colors
|
Hey @cpetry , would you mind rebasing this on latest master? I think the Normal Map issue has been fixed in the meantime, but the MaterialPropertyBlock is interesting to add. Not sure if passing it around that way is great as a lot of potential API surface changes with that though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30
This adds consideration of MaterialPropertyBlocks.
Tried to be as close to the existing code style as possible.
Related to #32
Fixed normal map interpretation in shader for correct export.
Looking good now.