-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #208 from AnweshCR7/Final-Issue-178
Fixed Filter not showing issue
- Loading branch information
Showing
4 changed files
with
581 additions
and
439 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ sudo: required | |
dist: trusty | ||
language: node_js | ||
node_js: | ||
- stable | ||
- 9 | ||
branches: | ||
except: | ||
- gh-pages | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
bc247d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evanjd Thanks for your help Evan. I'll be careful for the upcoming PRs. Also, I would like to know if I need to push the changes you made, to pass the CI test?
bc247d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnweshCR7 I pushed them to your branch already, that's how CI passed in the first place.
Also, no problem. 👍
bc247d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evanjd Yeah.. I need to make a new PR, for another fix. Which is why I was asking if I would be required to make those changes Locally before pushing it.
bc247d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnweshCR7 Ah. In that case, create a new branch from master and pull from upstream to get the latest changes.
https://help.github.com/articles/configuring-a-remote-for-a-fork/
then
https://help.github.com/articles/syncing-a-fork/