Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Ogury #4082

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

New Adapter: Ogury #4082

wants to merge 9 commits into from

Conversation

krdzo
Copy link

@krdzo krdzo commented Nov 28, 2024

PR for the documentation prebid/prebid.github.io#5742

adapters/ogury/ogury.go Outdated Show resolved Hide resolved
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cfc66d0

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:28:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:119:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:149:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:164:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:176:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:196:	MakeBids		70.0%
total:								(statements)		75.8%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1125795

ogury

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:26:	MakeRequests		75.7%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:117:	filterValidImps		92.9%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:147:	getAdUnitCode		87.5%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:162:	setHeaders		57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:174:	getMediaTypeForBid	57.1%
github.com/prebid/prebid-server/v3/adapters/ogury/ogury.go:194:	MakeBids		70.0%
total:								(statements)		75.5%

@krdzo
Copy link
Author

krdzo commented Dec 3, 2024

Hello I have a question with this PR.
We are using adUnitCode in our backend and I wanted to read it from imp[].Ext.Prebid.AdUnitCode but I see that this field is not forwarded to bidders (also opened this issue #4077 to see if this is a bug or intended behaviour), so we using imp.Id as a fallback for adunitcode.
Is this a right assumption, can we relay on imp[].id to always have adUnitCode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant