feat: add nativery prebid adapter #4074
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // getMediaTypeForBid switch nativery type in bid type. | ||
| func getMediaTypeForBid(bid *bidExt) (openrtb_ext.BidType, error) { | ||
| switch bid.Nativery.BidType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
|
|
||
| // getMediaTypeForBid switch nativery type in bid type. | ||
| func getMediaTypeForBid(bid *bidExt) (openrtb_ext.BidType, error) { | ||
| switch bid.Nativery.BidType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
|
|
||
| // getMediaTypeForBid switch nativery type in bid type. | ||
| func getMediaTypeForBid(bid *bidExt) (openrtb_ext.BidType, error) { | ||
| switch bid.Nativery.BidType { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
No description provided.