Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp #4000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pubmatic: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp #4000

wants to merge 2 commits into from

Conversation

AvinashKapre
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0f5553e

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:85:	MakeRequests				92.2%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:195:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:238:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:246:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:254:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:351:	extractPubmaticExtFromRequest		96.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:435:	MakeBids				90.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:517:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:539:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:551:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:564:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:579:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:629:	getStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:642:	getBidType				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:662:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:671:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.1%

@SyntaxNode SyntaxNode changed the title Forward displaymanager and displaymanagerver from app extension to pubmatic ssp Pubmatic: Forward displaymanager and displaymanagerver from app extension to pubmatic ssp Oct 21, 2024
SyntaxNode
SyntaxNode reviewed Oct 21, 2024
View reviewed changes
adapters/pubmatic/pubmatic_test.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coded unit tests are fine, but we look at the json test coverage since that includes additional assertions for memory safety. Please add json tests to cover this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyntaxNode Can you please review the latest changes?

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 38ea889

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:85:	MakeRequests				93.8%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:195:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:238:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:246:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:254:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:351:	extractPubmaticExtFromRequest		96.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:435:	MakeBids				90.7%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:517:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:539:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:551:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:564:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:579:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:629:	getStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:642:	getBidType				100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:662:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/pubmatic/pubmatic.go:671:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.4%

@pm-isha-bharti
Copy link
Contributor

@SyntaxNode Can you please review and merge the latest changes?

@pm-isha-bharti
Copy link
Contributor

pm-isha-bharti commented Nov 26, 2024 •
edited
Loading

Hi @bsardo / @SyntaxNode

Can you please review and merge this PR?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-isha-bharti pm-isha-bharti pm-isha-bharti left review comments

@SyntaxNode SyntaxNode SyntaxNode left review comments

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AvinashKapre @pm-isha-bharti @SyntaxNode @przemkaczmarek @bsardo