Smaato: Send imp.ext object entirely #3995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
Enigo
force-pushed
the
feature/PREB-42_O_add_gpid_support
branch
from
4d58f1f
to
ae02b61
Compare
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
przemkaczmarek
previously approved these changes
Oct 23, 2024
|
Hi @Enigo, can you please merge with master (no rebase) and resolve conflicts? Thanks! |
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
|
@bsardo |
przemkaczmarek
previously approved these changes
Nov 5, 2024
|
@bsardo |
bsardo
reviewed
Nov 27, 2024
adapters/smaato/smaato.go
Outdated
| @@ -513,33 +514,33 @@ func setImpForAdBreak(imps []openrtb2.Imp) error { | |||
| imps[i].Video = &videoCopy | |||
| } | |||
|
|
|||
| imps[0].Ext = impExt | |||
| imps[0].Ext = ext | |||
There was a problem hiding this comment.
Nitpick: I think you can get rid of the ext variable and instead just assign firstImp.Ext to imps[0].Ext.
Comment on lines
+528
to
+531
| err := jsonparser.ObjectEach(updatedExt, func(key []byte, value []byte, dataType jsonparser.ValueType, offset int) error { | ||
| isEmpty = false | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
👍 this is an interesting approach. I imagine this is much faster than unmarshaling to a map and checking the length.
Code coverage summaryNote:
smaatoRefer here for heat map coverage report |
bsardo
approved these changes
Dec 2, 2024
przemkaczmarek
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way how our adapter sends the
imp.extobject to the ad server - now the entire object is sent and not onlyskadn