Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Roundhouseads #3977

Closed
wants to merge 41 commits into from

Conversation

juliansalinas121
Copy link

Summary

This PR introduces the RoundhouseAds bidder adapter for Prebid Server. It supports the following media types:

  • Banner
  • Video
  • Native

Endpoints

GDPR and GPP Compliance

  • GVL Vendor ID: Using 42 temporarily until registration with IAB.
  • GPP Supported: Yes

Test Status

  • Unit tests: All tests passed.
  • JSON tests: Exemplary and supplemental tests added.

Maintainer

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, be82def

roundhouseads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:173:	Builder		91.7%
total:										(statements)	97.7%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 429de15

roundhouseads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:173:	Builder		91.7%
total:										(statements)	97.7%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, be68f9f

roundhouseads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:173:	Builder		91.7%
total:										(statements)	97.7%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 626d158

roundhouseads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:29:	MakeRequests	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:102:	getPublisherId	90.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:122:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:160:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/roundhouseads/roundhouseads.go:173:	Builder		91.7%
total:										(statements)	97.7%

@juliansalinas121
Copy link
Author

juliansalinas121 commented Oct 14, 2024

Hi Prebid team, this PR adds the Roundhouseads adapter. Please let me know if any further changes are needed. Thanks for reviewing!

@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @juliansalinas121, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@juliansalinas121
Copy link
Author

Hi @bsardo, I'm closing this PR in favor of PR #4037, which includes the requested v3 updates and a merge with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants