Flipp: use height value from server response #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds in decisions response (#8) * add compactHeight and standardHeight fields in decision response * modify tests * modify tests * modify tests * modify tests * adding height to expectedBidResponses * final testing * final changes * final changes * final changes
Code coverage summaryNote:
flippRefer here for heat map coverage report |
MishelleBit
changed the title
|
Hi, could I please get two reviews to proceed with this change? Thank you @przemkaczmarek @bsardo @onkarvhanumante @minaguib @dlackty @dmitris @asweeney86 @hhhjort |
|
Hi @przemkaczmarek, I hope you're doing well. Can we get an update on this? |
przemkaczmarek
previously approved these changes
Oct 23, 2024
|
Hello, could I please get another review to proceed with this change? Thank you @bsardo @onkarvhanumante @minaguib @dlackty @dmitris @asweeney86 @hhhjort |
|
Hi @bsardo , I hope you're doing well. Can we get an update on this? |
|
Hi @MishelleBit, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are |
Code coverage summaryNote:
flippRefer here for heat map coverage report |
Code coverage summaryNote:
flippRefer here for heat map coverage report |
|
Hi @bsardo, done! |
|
Hi @bsardo I hope you're doing well, can we get an update? |
SyntaxNode
reviewed
Nov 17, 2024
adapters/flipp/flipp.go
Outdated
| @@ -231,7 +243,20 @@ func buildBid(decision *InlineModel, impId string) *openrtb2.Bid { | |||
| if decision.Contents[0].Data.Width != 0 { | |||
| bid.W = decision.Contents[0].Data.Width | |||
| } | |||
| bid.H = 0 | |||
| customDataInterface := decision.Contents[0].Data.CustomData | |||
| customDataMap := customDataInterface.(map[string]interface{}) | |||
There was a problem hiding this comment.
Please add a test case where customdata is a different type to verify this adapter code gracefully handles and error and doesn't panic on an incorrect response.
Code coverage summaryNote:
flippRefer here for heat map coverage report |
|
Thanks @SyntaxNode ! It should handle different types and i've set |
przemkaczmarek
approved these changes
Nov 25, 2024
|
Hi @przemkaczmarek can you please reapprove? thank you! |
|
Hi @SyntaxNode can you please reapprove? thank you! |
przemkaczmarek
previously approved these changes
Nov 27, 2024
|
@SyntaxNode Hello, you previously approved can you please re-approve? thank you. |
VeronikaSolovei9
previously approved these changes
Dec 10, 2024
bsardo
reviewed
Dec 10, 2024
adapters/flipp/flipp.go
Outdated
| if err != nil { | ||
| return nil, []error{fmt.Errorf("flipp params not found. %v", err)} | ||
| } | ||
| err = json.Unmarshal(params, &flippExtParams) |
There was a problem hiding this comment.
Please use jsonutil.Unmarshal instead.
MishelleBit
dismissed stale reviews from VeronikaSolovei9 and przemkaczmarek
via
7c84694
MishelleBit
requested review from
bsardo,
VeronikaSolovei9 and
przemkaczmarek
Code coverage summaryNote:
flippRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Dec 10, 2024
VeronikaSolovei9
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using standardHeight and compactHeight from server response. Modified some tests accordingly as well.