Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeta Global SSP: Add sid parameter and audio support #3939

Closed
wants to merge 1 commit into from
Closed

Zeta Global SSP: Add sid parameter and audio support #3939

wants to merge 1 commit into from

Conversation

abermanov-zeta
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 01be5a3

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

@abermanov-zeta abermanov-zeta mentioned this pull request Sep 25, 2024
Open
2 tasks
@przemkaczmarek przemkaczmarek self-assigned this Oct 10, 2024
@przemkaczmarek przemkaczmarek self-requested a review October 10, 2024 13:24
@bsardo bsardo changed the title Zeta Global SSP Adapter: add 'sid' parameter, add audio support. Zeta Global SSP: Add sid parameter and audio support Oct 10, 2024
przemkaczmarek
przemkaczmarek reviewed Oct 22, 2024
View reviewed changes
static/bidder-info/zeta_global_ssp.yaml
@@ -1,5 +1,8 @@
endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
disabled: true
endpoint: https://ssp.disqus.com/bid/prebid-server?sid={{.AccountID}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable;
Uploading image.png…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek I'm sorry, I didn't get it (cannot upload your img). Yes, the endpoint is reachable. And sid query param is not mandatory in current implementation. What is the issue here?

Copy link
Collaborator

@przemkaczmarek przemkaczmarek Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abermanov-zeta its not a issue, we just checking that endpoint is reachable. To merge PR 2ppl have to accept it. So if i check endpoint secound person dont have to.
When Ypu have cheanged endpoinyt we Have to check it one more time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek got it, thank you

bsardo
bsardo reviewed Oct 22, 2024
View reviewed changes
static/bidder-info/zeta_global_ssp.yaml
userSync:
redirect:
url: https://ssp.disqus.com/redirectuser?sid=GET_SID_FROM_ZETA&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}
url: https://ssp.disqus.com/redirectuser?sid={{.AccountID}}&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccountID is not currently a supported macro for user sync URLs. We can add it. It should be noted that if it is not provided in the request to the cookie sync endpoint, the account ID will be set to "unknown".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo Yes, thank you. I've seen lists in macros.go. Having it in userSync is not critical for us, but would be great to have.

@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@abermanov-zeta
Copy link
Contributor Author

Closing this MR due to #3849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemkaczmarek przemkaczmarek przemkaczmarek left review comments

@bsardo bsardo bsardo left review comments

Assignees

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abermanov-zeta @bsardo @przemkaczmarek