New Adapter: Zentotem #3866

zentotem · 2024-08-16T23:20:07Z

Docs: prebid/prebid.github.io#5553

add adapter for zentotem

github-actions · 2024-08-16T23:20:40Z

adapters/zentotem/zentotem.go

+		var bidExt openrtb_ext.ExtBid
+		err := json.Unmarshal(bid.Ext, &bidExt)
+		if err == nil && bidExt.Prebid != nil {
+			return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-16T23:20:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b3caeaa

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	33.3%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:72:	MakeBids		86.4%
total:									(statements)		76.1%

@gg-natalia

authored by @gg-natalia

add adapter for zentotem

github-actions · 2024-08-20T16:59:19Z

adapters/zentotem/zentotem.go

+}
+
+func getMediaTypeForBid(imp openrtb2.Imp) (openrtb_ext.BidType, error) {
+	if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T16:59:20Z

adapters/zentotem/zentotem.go

+		return openrtb_ext.BidTypeNative, nil
+	}
+
+	if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T16:59:21Z

adapters/zentotem/zentotem.go

+		return openrtb_ext.BidTypeBanner, nil
+	}
+
+	if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T16:59:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f075a67

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	0.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:76:	MakeBids		75.9%
total:									(statements)		66.7%

add adapter for zentotem

github-actions · 2024-08-20T17:28:40Z

adapters/zentotem/zentotem.go

+}
+
+func getMediaTypeForBid(imp openrtb2.Imp) (openrtb_ext.BidType, error) {
+	if imp.Native != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T17:28:41Z

adapters/zentotem/zentotem.go

+		return openrtb_ext.BidTypeNative, nil
+	}
+
+	if imp.Banner != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T17:28:42Z

adapters/zentotem/zentotem.go

+		return openrtb_ext.BidTypeBanner, nil
+	}
+
+	if imp.Video != nil {


Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeVideo, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2024-08-20T17:28:52Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6f3f47c

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	85.7%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:76:	MakeBids		75.9%
total:									(statements)		77.8%

zentotem · 2024-08-20T17:28:56Z

Hello! Apologies for making some changes during the review process, but I had to change “getMediaTypeForBid”

gargcreation1992 · 2024-08-21T09:29:42Z

adapters/zentotem/zentotem.go

+	if request == nil {
+		return nil, []error{&errortypes.BadInput{Message: "empty request"}}
+	}
+	if len(request.Imp) == 0 {
+		return nil, []error{&errortypes.BadInput{Message: "empty request.Imp"}}
+	}


No need to perform these checks. These are covered by the core predid server code.

gargcreation1992 · 2024-08-21T09:30:23Z

adapters/zentotem/zentotem.go

+	return requests, errors
+}
+
+func getMediaTypeForBid(imp openrtb2.Imp) (openrtb_ext.BidType, error) {


Requesting you to please re-write this function to use MType field.

gargcreation1992 · 2024-08-21T09:31:09Z

adapters/zentotem/zentotem.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: "Unexpected status code: 400. Bad request from publisher. Run with request.debug = 1 for more info.",
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}


Please reuse -

if adapters.IsResponseStatusCodeNoContent(responseData) { return nil, nil } if err := adapters.CheckResponseStatusCodeForErrors(responseData); err != nil { return nil, []error{err} }

gargcreation1992 · 2024-08-21T09:32:10Z

adapters/zentotem/zentotem.go

+	impMap := map[string]openrtb2.Imp{}
+	for _, imp := range request.Imp {
+		impMap[imp.ID] = imp
+	}


You should not be creating the impMap if you use Mtype field set in the bid response.

gargcreation1992 · 2024-08-21T09:33:54Z

static/bidder-info/zentotem.yaml

@@ -0,0 +1,16 @@
+endpoint: "https://rtb.zentotem.net/bid?sspuid=cqlnvfk00bhs0b6rci6g"
+maintainer:
+  email: [email protected]


sent email for verification.

we sent a response letter for verification

Co-authored-by: hhhjort <[email protected]> Co-authored-by: Veronika Solovei <[email protected]>

Co-authored-by: VeronikaSolovei9 <[email protected]>

bsardo · 2024-11-04T16:34:39Z

Hi @zentotem, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

add adapter for zentotem

fix after review

replace v2 to v3

# Conflicts: # adapters/zentotem/params_test.go # adapters/zentotem/zentotem.go # adapters/zentotem/zentotem_test.go # exchange/adapter_builders.go

GermanBogatov and others added 8 commits July 2, 2024 12:42

zentotem: add adapter

9aef1ae

add adapter for zentotem

zentotem: add adapter

6fdcc11

add adapter for zentotem

zentotem: add adapter

3edd765

add adapter for zentotem

zentotem: add adapter

9ec095a

add adapter for zentotem

zentotem: add adapter

a7d9462

add adapter for zentotem

zentotem: add adapter

36a4b0f

add adapter for zentotem

zentotem: add adapter

9c6b5e3

add adapter for zentotem

Merge branch 'prebid:master' into master

b3caeaa

github-actions bot reviewed Aug 16, 2024

View reviewed changes

ADTS-455 remove video validations (prebid#3842)

e4bd6d3

authored by @gg-natalia

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Aug 19, 2024

GermanBogatov added 2 commits August 20, 2024 19:58

zentotem: add adapter

153ebf5

add adapter for zentotem

Merge remote-tracking branch 'origin/master'

f075a67

github-actions bot reviewed Aug 20, 2024

View reviewed changes

zentotem: add adapter

6f3f47c

add adapter for zentotem

github-actions bot reviewed Aug 20, 2024

View reviewed changes

gargcreation1992 reviewed Aug 21, 2024

View reviewed changes

ishihanvcs and others added 8 commits October 29, 2024 11:34

ImproveDigital: Remove placementKey & addtlconsent parsing (prebid#3728)

a23380f

Update Cookie Sync Chooser Debug Message to match Java (prebid#3558)

ddf897c

Rename Blacklisted Apps to Blocked Apps (prebid#3620)

1419761

ORTB 2.6: Full support with down convert for 2.5 adapters (prebid#4019)

db2a872

Co-authored-by: hhhjort <[email protected]> Co-authored-by: Veronika Solovei <[email protected]>

Cookie Sync: Use max when limit is 0 (prebid#4022)

df58baf

Remove Default Request Hardcoded Aliases (prebid#4020)

3907f1a

Adapters: Update to use jsonutil unmarshal (prebid#4021)

5b11f59

Co-authored-by: VeronikaSolovei9 <[email protected]>

Increment Package Version To v3 (prebid#4029)

6e150f3

MartinGumGum and others added 19 commits November 4, 2024 14:14

GumGum: Override the default currency (prebid#3928)

a788661

PgamSSP: Add currency converter (prebid#3907)

3403544

IQzone: Add user sync (prebid#3971)

106f6e4

Fix: Delete user.ext.prebid.buyeruids after extraction (prebid#4049)

181d523

Krushmedia: Update user sync urls (prebid#3979)

24ba83b

New Adapter: Nativo (prebid#3790)

63af8af

zentotem: add adapter

573c59e

add adapter for zentotem

zentotem: add adapter

f8ee4ed

add adapter for zentotem

zentotem: add adapter

4bee7d9

add adapter for zentotem

zentotem: add adapter

5cb43d2

add adapter for zentotem

zentotem: add adapter

b6bc533

add adapter for zentotem

zentotem: add adapter

39567ab

add adapter for zentotem

zentotem: add adapter

93e3969

add adapter for zentotem

zentotem: add adapter

bd22820

add adapter for zentotem

zentotem: add adapter

2b0b9b1

add adapter for zentotem

zentotem: fix after review

7a2144a

fix after review

zentotem: fix after review

d4290d3

fix after review

zentotem: replace v2 to v3

764f48a

replace v2 to v3

Merge remote-tracking branch 'origin/master'

dc73050

# Conflicts: # adapters/zentotem/params_test.go # adapters/zentotem/zentotem.go # adapters/zentotem/zentotem_test.go # exchange/adapter_builders.go

zentotem dismissed gargcreation1992’s stale review via dc73050 November 13, 2024 21:53

zentotem closed this Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Zentotem #3866

New Adapter: Zentotem #3866

zentotem commented Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot Aug 20, 2024

github-actions bot Aug 20, 2024

github-actions bot Aug 20, 2024

github-actions bot commented Aug 20, 2024

github-actions bot Aug 20, 2024

github-actions bot Aug 20, 2024

github-actions bot Aug 20, 2024

github-actions bot commented Aug 20, 2024

zentotem commented Aug 20, 2024

gargcreation1992 Aug 21, 2024

zentotem Aug 22, 2024

gargcreation1992 Aug 21, 2024

zentotem Aug 22, 2024

gargcreation1992 Aug 21, 2024

zentotem Aug 22, 2024

gargcreation1992 Aug 21, 2024

zentotem Aug 22, 2024

gargcreation1992 Aug 21, 2024

zentotem Aug 22, 2024

bsardo commented Nov 4, 2024

New Adapter: Zentotem #3866

New Adapter: Zentotem #3866

Conversation

zentotem commented Aug 16, 2024

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 16, 2024

Code coverage summary

zentotem

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 20, 2024

Code coverage summary

zentotem

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot Aug 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 20, 2024

Code coverage summary

zentotem

zentotem commented Aug 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fixed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsardo commented Nov 4, 2024