Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Intertech #3718
base: master
Are you sure you want to change the base?
New Adapter: Intertech #3718
Changes from 10 commits
b3ed88e
0274c44
a123a0d
b7d5642
2b1b727
3e2bc40
f0649d6
46863fd
3dad03f
6da959d
b1222c5
72d3738
6f3c68f
cbd5d1c
b16e499
4745c28
80beb1c
7695a5e
f21611f
09f7073
7eb7569
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these don't involve
request.Device
, I suggest moving these outside of the conditional so that they are always set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this adapter only supports banner and native, the bid type is derived from the impression and PBS core will only call the adapter if an impression is one of the supported formats, this error case should not be possible. This function could be simplified as follows: