Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive bidder name in ext.prebid.data.eidpermissions.bidders #3127

Closed
wants to merge 6 commits into from

Conversation

onkarvhanumante
Copy link
Contributor

PR makes changes to support case insensitive bidder names in ext.prebid.data.eidpermissions.bidders.

As shown below bidder name appnexus is known name to PBS. But APPNEXUS is unknown. Prior to PR changes PBS would have error out with unknown APPNEXUS bidder name messgae. PR has implemented insensitive bidder name comparison in ext.prebid.data.eidpermissions.bidders

        "ext": {
            "prebid": {
                "data": {
                    "eidpermissions": [
                        {
                            "source": "source1",
                            "bidders": [
                                "APPNEXUS" //  sensitive bidder name
                            ]
                        }
                    ]
                }
          }

Base automatically changed from PBS-1254-1 to master September 25, 2023 16:53
@gargcreation1992 gargcreation1992 dismissed their stale review September 25, 2023 16:53

The base branch was changed.

@onkarvhanumante
Copy link
Contributor Author

onkarvhanumante commented Sep 25, 2023

Closing this PR because commit got messed up after base branch PBS-1254-1 was deleted.

New PR - #3141

@onkarvhanumante onkarvhanumante deleted the eids-case-insensitive-bidder-name branch September 25, 2023 18:44
@bsardo bsardo removed the PBS 2.0 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants