Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Prometheus Type Conversions #3106

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Cleanup Prometheus Type Conversions #3106

merged 1 commit into from
Sep 20, 2023

Conversation

SyntaxNode
Copy link
Contributor

Use generics to eliminate boilerplate code in Prometheus preload type conversions.

@hhhjort hhhjort self-assigned this Sep 14, 2023
@hhhjort hhhjort self-requested a review September 14, 2023 17:14
bsardo
bsardo approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hhhjort
hhhjort approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode merged commit 55302c6 into prebid:master Sep 20, 2023
3 checks passed
@SyntaxNode SyntaxNode deleted the metrics-generics branch September 26, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhhjort hhhjort hhhjort approved these changes

@bsardo bsardo bsardo approved these changes

Assignees

@bsardo bsardo

@hhhjort hhhjort

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyntaxNode @bsardo @hhhjort