Fix few adapter aliases bug #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer require to maintain aliasBidderNames in separate slice. Instead, we will be needing aliasBidderToParentBidder map to maintain so that we can use it to get parent schema in later commit.
This refactor makes it easier to test the NewBidderParamsValidator function. Also adds the test cases.
This is required to fix the issue where we read bidderInfo first, check if it is an alias and then SetAliasBidderName. So that normalizeBidderName returns the dynamically added alias names.
# Conflicts: # config/bidderinfo.go # openrtb_ext/bidders.go # openrtb_ext/bidders_test.go
config/bidderinfo.go
Outdated
| //required for CoreBidderNames function to also return aliasBiddernames | ||
| openrtb_ext.SetAliasBidderName(openrtb_ext.BidderName(string(bidderName))) | ||
| if err := openrtb_ext.SetAliasBidderName(openrtb_ext.BidderName(string(bidderName)), openrtb_ext.BidderName(aliasBidderInfo.AliasOf)); err != nil { |
There was a problem hiding this comment.
bidderName need be typecasted to string as it is already a string. We have done these changes in this commit
There was a problem hiding this comment.
This should be done in the merge master commit.
| @@ -552,11 +556,11 @@ var bidderNameLookup = func() map[string]BidderName { | |||
| lookup[bidderNameLower] = name | |||
| } | |||
| return lookup | |||
| }() | |||
| } | |||
There was a problem hiding this comment.
mostly for my understanding, any specific reason to make this change?
There was a problem hiding this comment.
because of - #3055 (comment)
onkarvhanumante
approved these changes
Sep 4, 2023
VeronikaSolovei9
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes -
/bidders/paramsendpoint to also return aliases bidder params.