inherit bidder params from parent for an alias #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer require to maintain aliasBidderNames in separate slice. Instead, we will be needing aliasBidderToParentBidder map to maintain so that we can use it to get parent schema in later commit.
This refactor makes it easier to test the NewBidderParamsValidator function. Also adds the test cases.
openrtb_ext/bidders.go
Outdated
Comment on lines
597
to
602
| var paramsValidator paramsValidatorHelper = paramsHelper{} | ||
|
|
||
| // NewBidderParamsValidator makes a BidderParamValidator, assuming all the necessary files exist in the filesystem. | ||
| // This will error if, for example, a Bidder gets added but no JSON schema is written for them. | ||
| func NewBidderParamsValidator(schemaDirectory string) (BidderParamValidator, error) { | ||
| fileInfos, err := os.ReadDir(schemaDirectory) | ||
| fileInfos, err := paramsValidator.readDir(schemaDirectory) |
There was a problem hiding this comment.
Instead of declaring paramsValidator as package/global var. Update NewBidderParamsValidator to take paramsValidatorHelper interface as input.
Callers of NewBidderParamsValidator can then pass paramsValidator or mockParamsHelper as implementor
There was a problem hiding this comment.
Well, in that case we would need to make paramsValidatorHelper interface and paramsHelper struct public since caller of the NewBidderParamsValidator function is outside this package. IMO, caller should not worry about the implementation details of NewBidderParamsValidator function and should be handled within the package itself.
onkarvhanumante
previously approved these changes
Aug 28, 2023
SyntaxNode
reviewed
Aug 29, 2023
onkarvhanumante
approved these changes
Aug 31, 2023
Sonali-More-Xandr
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have adapter aliases that defines Bidder params explicitly using json file. However, after the adapter aliases feature, we will have the bidder params inherited from its parent adapter.
To accomplish this, we had to do some refactoring and remove the unnecessary code. We also refactored NewBidderParamsValidator function so that we can write the test cases.