Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.yml run build before creating new tag #3032

Merged
merged 5 commits into from
Sep 12, 2023
Merged

release.yml run build before creating new tag #3032

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c72134b
release.yml should run sucessful build before creating new tag
guscarreon Aug 15, 2023
9477772
Onkar's review
guscarreon Aug 16, 2023
6f9a560
Don't use make
guscarreon Aug 17, 2023
77f7ef2
swaped validate and build commands
guscarreon Aug 31, 2023
bdd780f
Remove unnecessary build command
guscarreon Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,24 @@ jobs:
outputs:
hasWritePermission: ${{ steps.check.outputs.require-result }}

build-master:
name: Build master
needs: check-permission
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
with:
fetch-depth: 0
- name: Build
uses: actions/checkout@master
uses: skx/github-action-build@master
with:
builder: make
Copy link
Contributor

@onkarvhanumante onkarvhanumante Aug 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few points here,

  • The two steps mentioned above checkouts master branch twice. Instead, we can checkout the branch once and then proceeding to the build step.
  • Build command will run successful even if certain unit tests fail. Should also execute the validate.sh script
  • Also should add if condition to check if hasWritePermission is true
 build-master:
    name: Build master
    needs: check-permission
    if: contains(needs.check-permission.outputs.hasWritePermission, 'true')
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@master
        with:
          fetch-depth: 0
          repository: ${{ github.repository }}
          ref: master
      - name: Validate and build
        run: |
          ./validate.sh
          make build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reivew. Addressed your comments in 9477772

The two steps mentioned above checkouts master branch twice. Instead, we can checkout the branch once and then proceeding to the build step.

Copy/paste error. Corrected

Build command will run successful even if certain unit tests fail. Should also execute the validate.sh script

Good point. Added. I ran the make command before validate though

Also should add if condition to check if hasWritePermission is true

Added


publish-tag:
name: Publish tag
needs: check-permission
needs: build-master
if: contains(needs.check-permission.outputs.hasWritePermission, 'true')
permissions:
contents: write
Expand Down