Fix currency conversion bug. (#3867)

Co-authored-by: ddubyk <[email protected]>
prebid · Aug 21, 2024 · a556e2d · a556e2d
1 parent d161712
commit a556e2d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/adapters/rubicon/rubicon.go b/adapters/rubicon/rubicon.go
@@ -317,9 +317,11 @@ func (a *RubiconAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *ada
 			continue
 		}
 
-		if resolvedBidFloor > 0 {
-			imp.BidFloorCur = "USD"
+		if resolvedBidFloor >= 0 {
 			imp.BidFloor = resolvedBidFloor
+			if imp.BidFloorCur != "" {
+				imp.BidFloorCur = "USD"
+			}
 		}
 
 		if request.User != nil {

diff --git a/adapters/rubicon/rubicon_test.go b/adapters/rubicon/rubicon_test.go
@@ -232,6 +232,14 @@ func TestOpenRTBRequestWithDifferentBidFloorAttributes(t *testing.T) {
 			expectedBidCur:   "",
 			expectedErrors:   nil,
 		},
+		{
+			bidFloor:         0,
+			bidFloorCur:      "EUR",
+			setMock:          func(m *mock.Mock) {},
+			expectedBidFloor: 0,
+			expectedBidCur:   "USD",
+			expectedErrors:   nil,
+		},
 		{
 			bidFloor:         -1,
 			bidFloorCur:      "CZK",