make NormalizeBidderName to do faster lookup

prebid · Sep 25, 2023 · 996dee0 · 996dee0
1 parent b9c2614
commit 996dee0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/openrtb_ext/bidders.go b/openrtb_ext/bidders.go
@@ -239,6 +239,7 @@ func SetAliasBidderName(aliasBidderName string, parentBidderName BidderName) err
 	aliasBidder := BidderName(aliasBidderName)
 	coreBidderNames = append(coreBidderNames, aliasBidder)
 	aliasBidderToParent[aliasBidder] = parentBidderName
+	bidderNameLookup[strings.ToLower(aliasBidderName)] = aliasBidder
 	return nil
 }
 
@@ -564,11 +565,11 @@ var bidderNameLookup = func() map[string]BidderName {
 		lookup[bidderNameLower] = name
 	}
 	return lookup
-}
+}()
 
 func NormalizeBidderName(name string) (BidderName, bool) {
 	nameLower := strings.ToLower(name)
-	bidderName, exists := bidderNameLookup()[nameLower]
+	bidderName, exists := bidderNameLookup[nameLower]
 	return bidderName, exists
 }
 

diff --git a/openrtb_ext/bidders_test.go b/openrtb_ext/bidders_test.go
@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"errors"
 	"os"
+	"strings"
 	"testing"
 	"testing/fstest"
 
@@ -148,6 +149,7 @@ func TestSetAliasBidderName(t *testing.T) {
 		} else {
 			assert.Contains(t, CoreBidderNames(), BidderName(test.aliasBidderName))
 			assert.Contains(t, aliasBidderToParent, BidderName(test.aliasBidderName))
+			assert.Contains(t, bidderNameLookup, strings.ToLower(test.aliasBidderName))
 		}
 	}