Implement TieEjector logic

prebid · Aug 15, 2023 · 8060ba4 · 8060ba4
1 parent b22b404
commit 8060ba4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/endpoints/setuid.go b/endpoints/setuid.go
@@ -173,7 +173,7 @@ func NewSetUIDEndpoint(cfg *config.Configuration, syncersByBidder map[string]use
 			so.Status = http.StatusBadRequest
 			return
 		}
-		priorityEjector := &usersync.PriorityBidderEjector{PriorityGroups: cfg.UserSync.PriorityGroups}
+		priorityEjector := &usersync.PriorityBidderEjector{PriorityGroups: cfg.UserSync.PriorityGroups, TieEjector: &usersync.OldestEjector{}}
 
 		// Write Cookie
 		encodedCookie, err := cookie.PrepareCookieForWrite(&cfg.HostCookie, encoder, priorityEjector)

diff --git a/usersync/cookie_test.go b/usersync/cookie_test.go
@@ -423,6 +423,7 @@ func TestPrepareCookieForWrite(t *testing.T) {
 				key: "7",
 			},
 		},
+		TieEjector: &OldestEjector{},
 	}
 
 	testCases := []struct {

diff --git a/usersync/ejector.go b/usersync/ejector.go
@@ -14,7 +14,7 @@ type OldestEjector struct{}
 type PriorityBidderEjector struct {
 	PriorityGroups  [][]string
 	syncersByBidder map[string]Syncer
-	OldestEjector   OldestEjector
+	TieEjector      Ejector
 }
 
 // Choose method for oldest ejector will return the oldest uid
@@ -36,7 +36,7 @@ func (o *OldestEjector) Choose(uids map[string]UIDEntry) (string, error) {
 func (p *PriorityBidderEjector) Choose(uids map[string]UIDEntry) (string, error) {
 	nonPriortyUids := getNonPriorityUids(uids, p.PriorityGroups, p.syncersByBidder)
 	if len(nonPriortyUids) > 0 {
-		return p.OldestEjector.Choose(nonPriortyUids)
+		return p.TieEjector.Choose(nonPriortyUids)
 	}
 
 	lowestPriorityGroup := p.PriorityGroups[len(p.PriorityGroups)-1]
@@ -48,7 +48,7 @@ func (p *PriorityBidderEjector) Choose(uids map[string]UIDEntry) (string, error)
 	}
 
 	lowestPriorityUids := getPriorityUids(lowestPriorityGroup, uids, p.syncersByBidder)
-	uidToDelete, err := p.OldestEjector.Choose(lowestPriorityUids)
+	uidToDelete, err := p.TieEjector.Choose(lowestPriorityUids)
 	if err != nil {
 		return "", err
 	}

diff --git a/usersync/ejector_test.go b/usersync/ejector_test.go
@@ -67,7 +67,7 @@ func TestPriorityEjector(t *testing.T) {
 						key: "olderButSamePriority",
 					},
 				},
-				OldestEjector: OldestEjector{},
+				TieEjector: &OldestEjector{},
 			},
 			expected: "olderButSamePriority",
 		},
@@ -110,6 +110,7 @@ func TestPriorityEjector(t *testing.T) {
 						key: "newestNonPriority",
 					},
 				},
+				TieEjector: &OldestEjector{},
 			},
 			expected: "oldestNonPriority",
 		},
-Original file line number
+Diff line change
@@ Expand Up / @@ -423,6 +423,7 @@ func TestPrepareCookieForWrite(t *testing.T) { @@
     				key: "7",
     			},
     		},
+    		TieEjector: &OldestEjector{},
     	}
     	testCases := []struct {
@@ Expand Down @@