-
Notifications
You must be signed in to change notification settings - Fork 748
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor tests and other small improvements
- Loading branch information
1 parent
f53c6e8
commit 46670fc
Showing
14 changed files
with
611 additions
and
615 deletions.
There are no files selected for viewing
281 changes: 50 additions & 231 deletions
281
modules/fiftyonedegrees/devicedetection/account_info_extractor_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,255 +1,74 @@ | ||
| package devicedetection | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "testing" | ||
|
|
||
| "github.com/prebid/openrtb/v20/openrtb2" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestPublisherIdExtractionFromSiteRequest(t *testing.T) { | ||
| var payload = []byte(` | ||
| var ( | ||
| siteRequestPayload = []byte(` | ||
| { | ||
| "imp": [ | ||
| { | ||
| "ext": { | ||
| "prebid": { | ||
| "storedrequest": { | ||
| "id": "p-bid-imp-test-005-banner-320x50" | ||
| }, | ||
| "adunitcode": "p-bid-config-test-005" | ||
| }, | ||
| "data": { | ||
| "pbadslot": "p-bid-config-test-005" | ||
| } | ||
| }, | ||
| "id": "p-bid-config-test-005", | ||
| "banner": { | ||
| "topframe": 1, | ||
| "format": [ | ||
| { | ||
| "w": 50, | ||
| "h": 320 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "site": { | ||
| "domain": "prebid.postindustria.com", | ||
| "publisher": { | ||
| "domain": "postindustria.com", | ||
| "id": "p-bid-config-test-005" | ||
| }, | ||
| "page": "https://prebid.postindustria.com/playground/page_with_prebid_js.html", | ||
| "ref": "https://prebid.postindustria.com/playground/" | ||
| }, | ||
| "device": { | ||
| "w": 345, | ||
| "h": 737, | ||
| "dnt": 0, | ||
| "ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36", | ||
| "language": "en", | ||
| "sua": { | ||
| "source": 2, | ||
| "platform": { | ||
| "brand": "macOS", | ||
| "version": [ | ||
| "14", | ||
| "0", | ||
| "0" | ||
| ] | ||
| }, | ||
| "browsers": [ | ||
| { | ||
| "brand": "Not A(Brand", | ||
| "version": [ | ||
| "99", | ||
| "0", | ||
| "0", | ||
| "0" | ||
| ] | ||
| }, | ||
| { | ||
| "brand": "Google Chrome", | ||
| "version": [ | ||
| "121", | ||
| "0", | ||
| "6167", | ||
| "184" | ||
| ] | ||
| }, | ||
| { | ||
| "brand": "Chromium", | ||
| "version": [ | ||
| "121", | ||
| "0", | ||
| "6167", | ||
| "184" | ||
| ] | ||
| "publisher": { | ||
| "id": "p-bid-config-test-005" | ||
| } | ||
| ], | ||
| "mobile": 0, | ||
| "model": "", | ||
| "architecture": "arm" | ||
| } | ||
| }, | ||
| "user": { | ||
| "data": [ | ||
| { | ||
| "ext": { | ||
| "segtax": 601, | ||
| "segclass": "4" | ||
| }, | ||
| "segment": [ | ||
| { | ||
| "id": "140" | ||
| } | ||
| ], | ||
| "name": "topics.authorizedvault.com" | ||
| }, | ||
| { | ||
| "ext": { | ||
| "segtax": 601, | ||
| "segclass": "4" | ||
| }, | ||
| "segment": [ | ||
| { | ||
| "id": "140" | ||
| } | ||
| ], | ||
| "name": "pa.openx.net" | ||
| } | ||
| ] | ||
| }, | ||
| "id": "3732c953-9af6-4fc0-95d6-f4fd45d4f90f", | ||
| "test": 0, | ||
| "ext": { | ||
| "prebid": { | ||
| "auctiontimestamp": 1708629526728, | ||
| "targeting": { | ||
| "includewinners": true, | ||
| "includebidderkeys": false | ||
| }, | ||
| "channel": { | ||
| "name": "pbjs", | ||
| "version": "v8.37.0" | ||
| }, | ||
| "createtids": false | ||
| } | ||
| } | ||
| } | ||
| `) | ||
|
|
||
| extractor := newAccountInfoExtractor() | ||
| accountInfo := extractor.extract(payload) | ||
|
|
||
| assert.Equal(t, accountInfo.Id, "p-bid-config-test-005") | ||
| } | ||
|
|
||
| func TestPublisherIdExtractionFromMobileRequest(t *testing.T) { | ||
| var payload = []byte(` | ||
| mobileRequestPayload = []byte(` | ||
| { | ||
| "app": { | ||
| "bundle": "org.prebid.PrebidDemoSwift", | ||
| "ext": { | ||
| "prebid": { | ||
| "source": "prebid-mobile", | ||
| "version": "2.1.6" | ||
| } | ||
| }, | ||
| "name": "PrebidDemoSwift", | ||
| "publisher": { | ||
| "id": "p-bid-config-test-005" | ||
| }, | ||
| "ver": "1.0" | ||
| }, | ||
| "device": { | ||
| "connectiontype": 2, | ||
| "ext": { | ||
| "atts": 0, | ||
| "ifv": "1B8EFA09-FF8F-4123-B07F-7283B50B3870" | ||
| }, | ||
| "h": 852, | ||
| "ifa": "00000000-0000-0000-0000-000000000000", | ||
| "language": "en", | ||
| "lmt": 1, | ||
| "make": "Apple", | ||
| "model": "iPhone", | ||
| "os": "iOS", | ||
| "osv": "17.0", | ||
| "pxratio": 3, | ||
| "ua": "Mozilla\/5.0 (iPhone; CPU iPhone OS 17_0 like Mac OS X) AppleWebKit\/605.1.15 (KHTML, like Gecko) Mobile\/15E148", | ||
| "w": 393 | ||
| }, | ||
| "ext": { | ||
| "prebid": { | ||
| "storedrequest": { | ||
| "id": "p-bid-config-test-005" | ||
| }, | ||
| "targeting": { | ||
| "publisher": { | ||
| "id": "p-bid-config-test-005" | ||
| } | ||
| } | ||
| }, | ||
| "id": "E17E1E6B-D3C4-4D09-8093-6E473390B717", | ||
| "imp": [ | ||
| { | ||
| "banner": { | ||
| "api": [ | ||
| 5 | ||
| ], | ||
| "format": [ | ||
| { | ||
| "h": 50, | ||
| "w": 320 | ||
| } | ||
| ] | ||
| }, | ||
| "clickbrowser": 1, | ||
| "ext": { | ||
| "prebid": { | ||
| "storedrequest": { | ||
| "id": "p-bid-imp-test-005-banner-320x50" | ||
| } | ||
| } | ||
| }, | ||
| "id": "830D74AA-D1F6-497D-8F3D-226BC99EA4FA", | ||
| "instl": 0, | ||
| "secure": 1 | ||
| } | ||
| ], | ||
| "source": { | ||
| "tid": "2B3E9156-4097-46FA-A58D-48A547BDB5FF" | ||
| } | ||
| } | ||
| `) | ||
|
|
||
| extractor := newAccountInfoExtractor() | ||
| accountInfo := extractor.extract(payload) | ||
|
|
||
| assert.Equal(t, accountInfo.Id, "p-bid-config-test-005") | ||
| } | ||
|
|
||
| func TestEmptyPublisherIdExtraction(t *testing.T) { | ||
| var payload = []byte(`{}`) | ||
|
|
||
| bReq := &openrtb2.BidRequest{} | ||
|
|
||
| err := json.Unmarshal(payload, &bReq) | ||
| assert.NoError(t, err) | ||
|
|
||
| extractor := newAccountInfoExtractor() | ||
| accountInfo := extractor.extract(payload) | ||
|
|
||
| assert.Nil(t, accountInfo) | ||
| } | ||
|
|
||
| func TestExtractionFromEmptyPayload(t *testing.T) { | ||
| extractor := newAccountInfoExtractor() | ||
| accountInfo := extractor.extract(nil) | ||
| emptyPayload = []byte(`{}`) | ||
| ) | ||
|
|
||
| assert.Nil(t, accountInfo) | ||
| func TestPublisherIdExtraction(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| payload []byte | ||
| expected string | ||
| expectNil bool | ||
| }{ | ||
| { | ||
| name: "SiteRequest", | ||
| payload: siteRequestPayload, | ||
| expected: "p-bid-config-test-005", | ||
| }, | ||
| { | ||
| name: "MobileRequest", | ||
| payload: mobileRequestPayload, | ||
| expected: "p-bid-config-test-005", | ||
| }, | ||
| { | ||
| name: "EmptyPublisherId", | ||
| payload: emptyPayload, | ||
| expectNil: true, | ||
| }, | ||
| { | ||
| name: "EmptyPayload", | ||
| payload: nil, | ||
| expectNil: true, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| extractor := newAccountInfoExtractor() | ||
| accountInfo := extractor.extract(tt.payload) | ||
|
|
||
| if tt.expectNil { | ||
| assert.Nil(t, accountInfo) | ||
| } else { | ||
| assert.Equal(t, tt.expected, accountInfo.Id) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.