-
Notifications
You must be signed in to change notification settings - Fork 748
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Imp FPD: Skip bidder params and native validation (#3720)
- Loading branch information
Showing
8 changed files
with
241 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
endpoints/openrtb2/sample-requests/invalid-whole/invalid-bidder-params.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"description": "Required appnexus bidder param is provided but the type is invalid", | ||
"config": { | ||
"realParamsValidator": true | ||
}, | ||
"mockBidRequest": { | ||
"id": "some-request-id", | ||
"site": { | ||
"page": "prebid.org" | ||
}, | ||
"imp": [ | ||
{ | ||
"id": "some-impression-id", | ||
"banner": { | ||
"format": [ | ||
{ | ||
"w": 300, | ||
"h": 250 | ||
}, | ||
{ | ||
"w": 300, | ||
"h": 600 | ||
} | ||
] | ||
}, | ||
"ext": { | ||
"appnexus": { | ||
"placementId": [] | ||
} | ||
} | ||
} | ||
], | ||
"tmax": 500, | ||
"ext": {} | ||
}, | ||
"expectedReturnCode": 400, | ||
"expectedErrorMessage": "Invalid request: request.imp[0].ext.prebid.bidder.appnexus failed validation.\nplacementId: Invalid type. Expected: [integer,string], given: array\n" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,137 @@ | ||
{ | ||
"requestType": "openrtb2-web", | ||
"incomingRequest": { | ||
"ortbRequest": { | ||
"id": "some-request-id", | ||
"site": { | ||
"page": "test.somepage.com" | ||
}, | ||
"imp": [ | ||
{ | ||
"id": "imp-id-1", | ||
"native": {}, | ||
"ext": { | ||
"prebid": { | ||
"bidder": { | ||
"appnexus": { | ||
"placementId": [] | ||
} | ||
}, | ||
"imp": { | ||
"appnexus": { | ||
"id": "imp-id-1-appnexus" | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
{ | ||
"id": "imp-id-2", | ||
"banner": { | ||
"format": [ | ||
{ | ||
"w": 300, | ||
"h": 600 | ||
} | ||
] | ||
}, | ||
"ext": { | ||
"prebid": { | ||
"bidder": { | ||
"appnexus": { | ||
"placementId": "123" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"outgoingRequests": { | ||
"appnexus": { | ||
"expectRequest": { | ||
"ortbRequest": { | ||
"id": "some-request-id", | ||
"site": { | ||
"page": "test.somepage.com" | ||
}, | ||
"imp": [ | ||
{ | ||
"id": "imp-id-1-appnexus", | ||
"native": {}, | ||
"ext": { | ||
"bidder": { | ||
"placementId": [] | ||
} | ||
} | ||
}, | ||
{ | ||
"id": "imp-id-2", | ||
"banner": { | ||
"format": [ | ||
{ | ||
"w": 300, | ||
"h": 600 | ||
} | ||
] | ||
}, | ||
"ext": { | ||
"bidder": { | ||
"placementId": "123" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"mockResponse": { | ||
"pbsSeatBids": [ | ||
{ | ||
"pbsBids": [ | ||
{ | ||
"ortbBid": { | ||
"id": "apn-bid", | ||
"impid": "imp-id-2", | ||
"price": 0.3, | ||
"w": 300, | ||
"h": 600, | ||
"crid": "creative-1" | ||
}, | ||
"bidType": "banner" | ||
} | ||
], | ||
"seat": "appnexus" | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
"response": { | ||
"bids": { | ||
"id": "some-request-id", | ||
"seatbid": [ | ||
{ | ||
"seat": "appnexus", | ||
"bid": [ | ||
{ | ||
"id": "apn-bid", | ||
"impid": "imp-id-2", | ||
"price": 0.3, | ||
"w": 300, | ||
"h": 600, | ||
"crid": "creative-1", | ||
"ext": { | ||
"origbidcpm": 0.3, | ||
"prebid": { | ||
"meta": {}, | ||
"type": "banner" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters