The conversant adapter apparently doesnt support apps. This makes it …

…explicit. (#623)
prebid · Jul 16, 2018 · 1300cbb · 1300cbb
1 parent 395107a
commit 1300cbb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/adapters/conversant/conversant.go b/adapters/conversant/conversant.go
@@ -50,6 +50,14 @@ func (a *ConversantAdapter) Call(ctx context.Context, req *pbs.PBSRequest, bidde
 		return nil, err
 	}
 
+	// Without this, the code crashes with a nil-pointer dereference below, on
+	// cnvrReq.Site.ID = params.SiteID
+	if cnvrReq.Site == nil {
+		return nil, &adapters.BadInputError{
+			Message: "Conversant doesn't support App requests",
+		}
+	}
+
 	// Create a map of impression objects for both request creation
 	// and response parsing.
 

diff --git a/static/bidder-info/conversant.yaml b/static/bidder-info/conversant.yaml
@@ -1,9 +1,6 @@
 maintainer:
   email: "[email protected]"
 capabilities:
-  app:
-    mediaTypes:
-      - banner
   site:
     mediaTypes:
       - banner