Core: fix bug where renderAd sometimes generates invisible iframes
#10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
changed the title
renderAd sometimes generates invisible iframes
dgirardi
force-pushed
the
fix-adUrl-renderAd
branch
from
315494e to
09dd00b
Compare
pez46
approved these changes
Nov 16, 2023
|
this fix will be merged in official prebid repository? |
patmmccann
approved these changes
Nov 20, 2023
|
#9647 also contains a fix for this and was just merged - should be out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #10734, regression introduced by #10441