Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum Bid Adapter: fix bug not passing GPP consent object as a string #10530

Merged
merged 1 commit into from
Sep 26, 2023
Merged

GumGum Bid Adapter: fix bug not passing GPP consent object as a string #10530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions modules/gumgumBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,15 +383,11 @@ function buildRequests(validBidRequests, bidderRequest) {
data.uspConsent = uspConsent;
}
if (gppConsent) {
data.gppConsent = {
gppString: bidderRequest.gppConsent.gppString,
gpp_sid: bidderRequest.gppConsent.applicableSections
}
data.gppString = bidderRequest.gppConsent.gppString ? bidderRequest.gppConsent.gppString : ''
data.gppSid = Array.isArray(bidderRequest.gppConsent.applicableSections) ? bidderRequest.gppConsent.applicableSections.join(',') : ''
} else if (!gppConsent && bidderRequest?.ortb2?.regs?.gpp) {
data.gppConsent = {
gppString: bidderRequest.ortb2.regs.gpp,
gpp_sid: bidderRequest.ortb2.regs.gpp_sid
};
data.gppString = bidderRequest.ortb2.regs.gpp
data.gppSid = Array.isArray(bidderRequest.ortb2.regs.gpp_sid) ? bidderRequest.ortb2.regs.gpp_sid.join(',') : ''
}
if (coppa) {
data.coppa = coppa;
Expand Down
20 changes: 10 additions & 10 deletions test/spec/modules/gumgumBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ describe('gumgumAdapter', function () {
let sizesArray = [[300, 250], [300, 600]];
let bidRequests = [
{
gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN',
gppSid: [7],
bidder: 'gumgum',
params: {
inSlot: 9
Expand Down Expand Up @@ -503,10 +505,9 @@ describe('gumgumAdapter', function () {
const gppConsent = { gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN', applicableSections: [7] }
const fakeBidRequest = { gppConsent: gppConsent };
const bidRequest = spec.buildRequests(bidRequests, fakeBidRequest)[0];
expect(bidRequest.data.gppConsent).to.exist;
expect(bidRequest.data.gppConsent.gppString).to.equal(gppConsent.gppString);
expect(bidRequest.data.gppConsent.gpp_sid).to.equal(gppConsent.applicableSections);
expect(bidRequest.data.gppConsent.gppString).to.eq('DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN');
expect(bidRequest.data.gppString).to.equal(gppConsent.gppString);
expect(bidRequest.data.gppSid).to.equal(gppConsent.applicableSections.join(','));
expect(bidRequest.data.gppString).to.eq('DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN');
});
it('should handle ortb2 parameters', function () {
const ortb2 = {
Expand All @@ -517,15 +518,14 @@ describe('gumgumAdapter', function () {
}
const fakeBidRequest = { gppConsent: ortb2 };
const bidRequest = spec.buildRequests(bidRequests, fakeBidRequest)[0];
expect(bidRequest.data.gppConsent.gppString).to.eq(fakeBidRequest[0])
expect(bidRequest.data.gpp).to.eq(fakeBidRequest[0])
});
it('should handle gppConsent is present but values are undefined case', function () {
const gppConsent = { gppString: undefined, applicableSections: undefined }
const fakeBidRequest = { gppConsent: gppConsent };
const bidRequest = spec.buildRequests(bidRequests, fakeBidRequest)[0];
expect(bidRequest.data.gppConsent).to.exist;
expect(bidRequest.data.gppConsent.gppString).to.equal(undefined);
expect(bidRequest.data.gppConsent.gpp_sid).to.equal(undefined);
expect(bidRequest.data.gppString).to.equal('');
expect(bidRequest.data.gppSid).to.equal('');
});
it('should handle ortb2 undefined parameters', function () {
const ortb2 = {
Expand All @@ -536,8 +536,8 @@ describe('gumgumAdapter', function () {
}
const fakeBidRequest = { gppConsent: ortb2 };
const bidRequest = spec.buildRequests(bidRequests, fakeBidRequest)[0];
expect(bidRequest.data.gppConsent.gppString).to.eq(undefined)
expect(bidRequest.data.gppConsent.gpp_sid).to.eq(undefined)
expect(bidRequest.data.gppString).to.eq('')
expect(bidRequest.data.gppSid).to.eq('')
});
it('should not set coppa parameter if coppa config is set to false', function () {
config.setConfig({
Expand Down