-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UID2: support Client-side token generation and build tag #10510
UID2: support Client-side token generation and build tag #10510
Conversation
@@ -3,7 +3,7 @@ | |||
<head> | |||
<link rel="icon" type="image/png" href="/favicon.png"> | |||
<script async src="//www.googletagservices.com/tag/js/gpt.js"></script> | |||
<script async src="prebid.js"></script> | |||
<script type="text/javascript" src="../../build/dev/prebid.js" async></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingyi-gao-ttd it looks like our integration tests are unable to run on this pr. This is likely because you are following a different instance of prebid in circleci such as a personal fork of it. If you go into circleci and unselect the prebid instance you are currently following on the left that should kick off our code integration tests :) |
@ChrisHuie Thanks Chris! I could integration tests are running now |
Uid2 decouple cstg
@patmmccann Thanks for the advice, we've added a feature flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did I miss a docs pull link? If so, is the build tag documented in it? |
We've prepared a pull request for documentation at #10629. However, at this stage, we would prefer not to widely promote the CSTG feature. We'd like to proceed with merging this feature for the next release without updating the documentation for now. @patmmccann, your insights on this matter would be appreciated. |
As discussed in slack, we're not able to merge sans documentation, particularly of the build flag |
Type of change
Description of change
This PR is to introduce the Client-side Token Generation (CSTG) mode to the UID2 module. Publishers now have the flexibility to generate UID2 tokens directly from the client side, eliminating the need for initial server-side token generation.
Other information
Since it's still backward compatible with existing functionality and we don't wanna widely advertise CSTG for now, we will not add CSTG to the UID2 module document until a few more pubs successfully use cstg inside prebid.js natively.
document PR: #10629