Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UID2: support Client-side token generation and build tag #10510

Merged
merged 44 commits into from
Oct 23, 2023

Conversation

jingyi-gao-ttd
Copy link
Contributor

@jingyi-gao-ttd jingyi-gao-ttd commented Sep 21, 2023

Type of change

  • Feature

Description of change

This PR is to introduce the Client-side Token Generation (CSTG) mode to the UID2 module. Publishers now have the flexibility to generate UID2 tokens directly from the client side, eliminating the need for initial server-side token generation.

Other information

Since it's still backward compatible with existing functionality and we don't wanna widely advertise CSTG for now, we will not add CSTG to the UID2 module document until a few more pubs successfully use cstg inside prebid.js natively.

document PR: #10629

@@ -3,7 +3,7 @@
<head>
<link rel="icon" type="image/png" href="/favicon.png">
<script async src="//www.googletagservices.com/tag/js/gpt.js"></script>
<script async src="prebid.js"></script>
<script type="text/javascript" src="../../build/dev/prebid.js" async></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This is the error I got when I trying to test esp_example, and I found this file hasn't been touch for a while now, so i am trying to fix the example

@ChrisHuie
Copy link
Collaborator

@jingyi-gao-ttd it looks like our integration tests are unable to run on this pr. This is likely because you are following a different instance of prebid in circleci such as a personal fork of it. If you go into circleci and unselect the prebid instance you are currently following on the left that should kick off our code integration tests :)

@jingyi-gao-ttd
Copy link
Contributor Author

@ChrisHuie Thanks Chris! I could integration tests are running now

@jingyi-gao-ttd jingyi-gao-ttd marked this pull request as draft September 22, 2023 04:15
@jingyi-gao-ttd jingyi-gao-ttd marked this pull request as ready for review September 22, 2023 05:27
@ChrisHuie ChrisHuie requested a review from dgirardi September 25, 2023 16:47
@jingyi-gao-ttd jingyi-gao-ttd marked this pull request as ready for review October 10, 2023 04:45
@jingyi-gao-ttd
Copy link
Contributor Author

@patmmccann Thanks for the advice, we've added a feature flag UID2_CSTG to be able to exclude CSTG code in the build. Could you please take another review?

Copy link
Collaborator

@dgirardi dgirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/uid2IdSystem_shared.js Show resolved Hide resolved
@patmmccann patmmccann changed the title UID2: support Client-side token generation UID2: support Client-side token generation and build tag Oct 18, 2023
@patmmccann
Copy link
Collaborator

Did I miss a docs pull link? If so, is the build tag documented in it?

@jingyi-gao-ttd
Copy link
Contributor Author

jingyi-gao-ttd commented Oct 19, 2023

Did I miss a docs pull link? If so, is the build tag documented in it?

We've prepared a pull request for documentation at #10629. However, at this stage, we would prefer not to widely promote the CSTG feature. We'd like to proceed with merging this feature for the next release without updating the documentation for now.

@patmmccann, your insights on this matter would be appreciated.

@patmmccann
Copy link
Collaborator

As discussed in slack, we're not able to merge sans documentation, particularly of the build flag

@patmmccann patmmccann merged commit d0e981b into prebid:master Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants