Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
peixunzhang committed Sep 22, 2023
1 parent fc1674b commit d8431f9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
8 changes: 4 additions & 4 deletions test/spec/modules/eids_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ describe('eids array generation for known sub-modules', function() {
});
});

it('openx',function () {
it('openx', function () {
const userId = {
openx: { 'id': 'sample_id' }
};
Expand All @@ -319,9 +319,9 @@ describe('eids array generation for known sub-modules', function() {
});
});

it('openx with ext',function () {
it('openx with ext', function () {
const userId = {
openx: { 'id': 'sample_id','ext': { 'provider': 'some.provider.com' } }
openx: { 'id': 'sample_id', 'ext': { 'provider': 'some.provider.com' } }
};
const newEids = createEidsArray(userId);
expect(newEids.length).to.equal(1);
Expand All @@ -336,7 +336,7 @@ describe('eids array generation for known sub-modules', function() {
}]
});
});

it('liveIntentId; getValue call and NO ext', function() {
const userId = {
lipb: {
Expand Down
7 changes: 4 additions & 3 deletions test/spec/modules/liveIntentIdMinimalSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,10 @@ describe('LiveIntentMinimalId', function() {
expect(result).to.eql({'lipb': {'lipbid': 'foo', 'nonId': 'foo', 'index': 'bar'}, 'index': {'id': 'bar', 'ext': {'provider': 'liveintent.com'}}});
});

it('should decode an openx id to a seperate object when present',function () {
const result = liveIntentIdSubmodule.decode({ nonId: 'foo',openx: 'bar' });
expect(result).to.eql({ 'lipb': { 'lipbid': 'foo','nonId': 'foo','openx': 'bar' },'openx': { 'id': 'bar','ext': { 'provider': 'liveintent.com' } } });
it('should decode an openx id to a seperate object when present', function () {
const result = liveIntentIdSubmodule.decode({ nonId: 'foo', openx: 'bar' });
expect(result).to.eql({'lipb': {'lipbid': 'foo', 'nonId': 'foo', 'openx': 'bar'}, 'openx': {'id': 'bar', 'ext': {'provider': 'liveintent.com'}}});
});

it('should allow disabling nonId resolution', function() {
let callBackSpy = sinon.spy();
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/liveIntentIdSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,9 @@ describe('LiveIntentId', function() {
expect(result).to.eql({'lipb': {'lipbid': 'foo', 'nonId': 'foo', 'index': 'bar'}, 'index': {'id': 'bar', 'ext': {'provider': 'liveintent.com'}}});
});

it('should decode an openx id to a seperate object when present',function () {
const result = liveIntentIdSubmodule.decode({ nonId: 'foo',openx: 'bar' });
expect(result).to.eql({ 'lipb': { 'lipbid': 'foo','nonId': 'foo','openx': 'bar' },'openx': { 'id': 'bar','ext': { 'provider': 'liveintent.com' } } });
it('should decode an openx id to a seperate object when present', function () {
const result = liveIntentIdSubmodule.decode({ nonId: 'foo', openx: 'bar' });
expect(result).to.eql({ 'lipb': { 'lipbid': 'foo', 'nonId': 'foo', 'openx': 'bar' }, 'openx': { 'id': 'bar', 'ext': { 'provider': 'liveintent.com' } } });
});

it('should allow disabling nonId resolution', function() {
Expand Down

0 comments on commit d8431f9

Please sign in to comment.