Skip to content

Commit

Permalink
Core: Adding useBaseGvlid to aliasBidAdapter (#12247)
Browse files Browse the repository at this point in the history
* Adding useBaseGvlid to aliasBidAdapter

* refactor

---------

Co-authored-by: Marcin Komorski <[email protected]>
  • Loading branch information
mkomorski and Marcin Komorski authored Sep 19, 2024
1 parent 38ecf2a commit 9a06e30
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/adapterManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -553,11 +553,13 @@ adapterManager.aliasBidAdapter = function (bidderCode, alias, options) {
newAdapter = new bidAdapter.constructor();
newAdapter.setBidderCode(alias);
} else {
const { useBaseGvlid = false } = options || {};
let spec = bidAdapter.getSpec();
let gvlid = options && options.gvlid;
if (spec.gvlid != null && gvlid == null) {
const gvlid = useBaseGvlid ? spec.gvlid : options?.gvlid;
if (gvlid == null && spec.gvlid != null) {
logWarn(`Alias '${alias}' will NOT re-use the GVL ID of the original adapter ('${spec.code}', gvlid: ${spec.gvlid}). Functionality that requires TCF consent may not work as expected.`)
}

let skipPbsAliasing = options && options.skipPbsAliasing;
newAdapter = newBidder(Object.assign({}, spec, { code: alias, gvlid, skipPbsAliasing }));
_aliasRegistry[alias] = bidderCode;
Expand Down
9 changes: 9 additions & 0 deletions test/spec/unit/core/adapterManager_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1630,6 +1630,15 @@ describe('adapterManager tests', function () {
expect(adapterManager.videoAdapters).to.include(alias);
}
});

it('should use gvlid of original adapter when option set', () => {
const gvlid = 'origvlid';
let thisSpec = Object.assign(spec, { gvlid });
registerBidder(thisSpec);
const alias = 'bidderWithGvlid';
adapterManager.aliasBidAdapter(CODE, alias, {useBaseGvlid: true});
expect(adapterManager.bidderRegistry[alias].getSpec()?.gvlid).to.deep.eql(gvlid);
})
});

describe('special case for s2s-only bidders', function () {
Expand Down

0 comments on commit 9a06e30

Please sign in to comment.