Currency module: Don't block 'responsesReady' when rates are present …

…and no conversion is done (#10736) * Currency module: Don't block 'responsesReady' when rates are present and no conversion is needed * Add test case for currency unnecessarily blocking auctions * Update currency_spec.js --------- Co-authored-by: Demetrio Girardi <[email protected]>
prebid · Nov 27, 2023 · 8993f74 · 8993f74
1 parent ecf4272
commit 8993f74
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/modules/currency.js b/modules/currency.js
@@ -148,6 +148,8 @@ function loadRates() {
         }
       }
     );
+  } else {
+    processBidResponseQueue();
   }
 }
 

diff --git a/test/spec/modules/currency_spec.js b/test/spec/modules/currency_spec.js
@@ -259,6 +259,19 @@ describe('currency', function () {
       expect(innerBid.getCpmInNewCurrency('JPY')).to.equal('100.000');
     });
 
+    it('does not block auctions if rates do not need to be fetched', () => {
+      sandbox.stub(responseReady, 'resolve');
+      setConfig({
+        adServerCurrency: 'USD',
+        rates: {
+          USD: {
+            JPY: 100
+          }
+        }
+      });
+      sinon.assert.called(responseReady.resolve);
+    })
+
     it('uses rates specified in json when provided and consider boosted bid', function () {
       setConfig({
         adServerCurrency: 'USD',
-Original file line number
+Diff line change
@@ Expand Up / @@ -148,6 +148,8 @@ function loadRates() { @@
             }
           }
         );
+      } else {
+        processBidResponseQueue();
       }
     }
@@ Expand Down @@