Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The enforced Prettier configurations should work in the build times. #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonaliBedade
Copy link

@sonaliBedade sonaliBedade commented Mar 1, 2021

Related Issue

  • Enforcing Prettier configurations

Closes: #36

Description

Added a file called prettierrc.json

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I made some changes in the existing code such that it will be modified by Prettier according to the stated configurations.

@praveenscience
Copy link
Owner

I guess we need to do more, look at the checks, it's not there:

image

Copy link
Owner

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have duplication plus this will not work on the CI. I guess we need to use something like husky! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce Prettier on commits and builds.
2 participants