Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #501 #503

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fixes #501 #503

merged 2 commits into from
Jul 11, 2024

Conversation

RobertDober
Copy link
Collaborator

@RobertDober RobertDober commented Jul 9, 2024

A little bit of a clumsy solution but I could not come up with something better w/o a major refact.

@dominicletz
Copy link

@amit-chaudhari1 what do you think of this solution? Would love to be able to get a new release with this bugfix ❤️

@amit-chaudhari1 amit-chaudhari1 merged commit d52fbbf into master Jul 11, 2024
6 checks passed
@amit-chaudhari1
Copy link
Collaborator

I will need @RobertDober 's help on creating a release.

@RobertDober
Copy link
Collaborator Author

I'll gladly do the release @amit-chaudhari1

Do you have release rights on hex.pm already? Would you like help with other things?

Also would you like me to keep annoncing Releases on the Elixir Forum?

@amit-chaudhari1
Copy link
Collaborator

Also would you like me to keep annoncing Releases on the Elixir Forum?

Yes please, for a while.

Do you have release rights on hex.pm already? Would you like help with other things?

No, I've registered on hex.pm but I don't think I can create the releases for earmark yet.
https://hex.pm/users/amyth

@RobertDober
Copy link
Collaborator Author

Released, I'll see if I can grant you release rights on hex, or If I need to ask Dave @amit-chaudhari1

@RobertDober
Copy link
Collaborator Author

@amit-chaudhari1 should be ok now

 mix hex.owner add --level maintainer earmark amyth                                                                                                               Local password:
Adding owner amyth with ownership level maintainer to earmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants