-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename EarmarkParser to Earmark.Parser to avoid conflicts #470
Conversation
Hi @RobertDober, I am aware you are looking for maintainers but if you could include this change and do a new release, it would be very much welcome and appreciated. Thank you very much for your time! ❤️ |
Now I am confused, I did not do this already? So it is I who thanx you as a matter of fact |
@@ -1,25 +1,25 @@ | |||
defmodule Earmark.EarmarkParserProxy do | |||
defmodule Earmark.Earmark.ParserProxy do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't help but notice, shouldn't this be Earmark.ParserProxy
(without the double Earmark
)? @josevalim
(Sorry if I'm off, I'm not familiar with the project)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good find. I can submit a PR. :) Although perhaps this module can be removed too. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or perhaps, since it is publicly documented, we should not change its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged it I did not understand why. I will be little available in the next days, shall I ask Dave to give you or some proxy of you (pun intended) commit rights here and also publish rights to hex.
I will merge and publish as much as I can, but maybe it would be good to have fallback options.
Again thank you for helping out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertDober there is no "technical" reason for the change, except that the module was publicly documented before, so it is best to not change its name in a patch version. :)
Regarding the package on Hex, there is no need to worry. If someday you decide to go on a well-deserved holidays/sabbatical/retirement and not touch a computer for several months, Hex has mechanisms in place to inherit a package after some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that explanation.
Otherwise, if a project depends on both earmark_parser and
earmark at the same time, the module will conflict with each
other.