Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cbmc-viewer version 3.9 #92

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

rod-chapman
Copy link
Contributor

@rod-chapman rod-chapman commented Aug 8, 2024

For compatibility with CBMC 6.1.1 and above, we should upgrade to cbmc-viewer 3.9

This PR updates the version number and hash for this in the NIX flake.

@rod-chapman rod-chapman requested a review from a team August 8, 2024 14:41
@rod-chapman rod-chapman changed the title Update version and hash to specify cbmc-viewer version 3.9 Update to cbmc-viewer version 3.9 Aug 8, 2024
@mkannwischer
Copy link
Contributor

mkannwischer commented Aug 9, 2024

I'm currently having some problems with this PR. Likely that is not actually related to this PR, but please don't merge this yet.
As expected this is an unrelated problem: https://github.com/pq-code-package/mlkem-c-aarch64/pull/93

Signed-off-by: Rod Chapman <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
@mkannwischer
Copy link
Contributor

I rebased this on top of #93.

@mkannwischer
Copy link
Contributor

Works fine on Linux and MacOS. Thanks @rod-chapman!

@mkannwischer mkannwischer merged commit ad56b2a into pq-code-package:main Aug 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants