-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor nix configuration on ci and the aarch64 gcc dependency on x86_64 machines #89
Refactor nix configuration on ci and the aarch64 gcc dependency on x86_64 machines #89
Conversation
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
I tested that I can cross compile on x86 and the produced binaries still run on A55. Functionally this is looking good for me. If you fix the one comment I had, we can get this merged. |
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
I can't test cross compilation since I only have aarch64 machines
Signed-off-by: Thing-han, Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @potsrevennil! This is much cleaner now!
I tested that everything still works on my laptop (cross-compiled + qemu) and on my RPi (natively).
1. Utilization of
pkgCross.aarch-multiplatform
:pkgCross.aarch-multiplatform
package inNix
is now used to set upGCC
targeting theAArch64
platform. This change enhances clarity and simplicity.arm-gnu-gcc.nix
file can thus be removed.AArch64
macOS
will continue using the nativeClang
compiler as per the original setup.2. Cross Prefix Modification:
pkgCross.aarch-multiplatform
has changed fromaarch64-none-linux-gnu-
toaarch64-unknown-linux-gnu-
.3. CI Configuration Refactor: