-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github benchmark action #78
Add github benchmark action #78
Conversation
a780699
to
3d53819
Compare
749b806
to
dca1876
Compare
2fd2773
to
61f6ce3
Compare
Signed-off-by: Matthias J. Kannwischer <[email protected]>
61f6ce3
to
33ccd2a
Compare
After lots of experimenting, I figured out that we cannot test this in a pull request. The maximum permission of the GITHUB_TOKEN in pull requests from forks on I have performed quite some tests in https://github.com/mkannwischer/bench-test today, and I believe that what we have here right now should work. |
Signed-off-by: Matthias J. Kannwischer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM
Signed-off-by: Matthias J. Kannwischer <[email protected]>
Signed-off-by: Matthias J. Kannwischer <[email protected]>
This adds benchmark visualization using https://github.com/benchmark-action/github-action-benchmark.
When ever a new commit is pushed to the
main
branch, it will upload the benchmarks to the https://github.com/pq-code-package/mlkem-c-aarch64/tree/gh-pages branch and they will be visualized at https://pq-code-package.github.io/mlkem-c-aarch64/dev/bench.This won't run on PRs (and it can't because these workflow runs won't have the permission to push commits -- see my comment below), so we can only see if it works the way it is intended if we merge it.
I have performed extensive tests here: https://github.com/mkannwischer/bench-test
And you can see how it should look like here: https://mkannwischer.github.io/bench-test/dev/bench/