Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bench workflow trigger more naturally #77

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

potsrevennil
Copy link
Contributor

@potsrevennil potsrevennil commented Jun 25, 2024

Follow the slothy approach as @hanno-becker and @mkannwischer suggested.

@potsrevennil potsrevennil changed the title use github.event.label for checking bench workflow trigger Make the bench workflow trigger more natrual Jun 25, 2024
@potsrevennil potsrevennil added the benchmark this PR should be benchmarked in CI label Jun 25, 2024
@potsrevennil potsrevennil changed the title Make the bench workflow trigger more natrual Make the bench workflow trigger more naturally Jun 25, 2024
@potsrevennil potsrevennil added bug Something isn't working benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Jun 25, 2024
@mkannwischer mkannwischer added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Jun 26, 2024
@potsrevennil potsrevennil marked this pull request as ready for review June 26, 2024 03:04
@potsrevennil potsrevennil requested a review from a team June 26, 2024 03:04
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @potsrevennil.
I tested it and it works as intended: When you add the benchmark label it benchmarks once. If you want to benchmark again, you need to remove the label and add it again.

@mkannwischer mkannwischer merged commit 6c0791e into pq-code-package:main Jun 26, 2024
10 checks passed
@potsrevennil potsrevennil deleted the bench-trigger branch June 26, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants