-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark workflow (RPi4 / Arm Cortex-A72) #69
Conversation
b4e1126
to
4e78bdd
Compare
4762b78
to
3d754dd
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to make the --cpu
to tests bench
optional and omit -march
if -mcpu
is specified.
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @potsrevennil, I confirm that --arch-flags
works.
May I ask for one more usability improvement: For perf
, I have to run the binaries with sudo
, but somehow sudo ./scripts/test ...
doesn't work (and is also not ideal, because the build itself really needs not sudo rights).
Can you add an option to the test script which builds only, and prints the names of the files that have been produced?
@hanno-becker Yeah, I agree with you that it indeed makes more sense in some cases to separate building and running the binary. There're also cases that we would like to run the binaries in a different machine. However, I'm thinking this might a bit out of scope for this PR, maybe we could open an issue to address this more, and make it a separate PR. What do you think ? |
@potsrevennil Ok! |
This PR depends on #68
I Added a benchmark workflow. Note that the workflow will only run on
main
branch or PR labeled asbenchmark
. Thetests
script is also refactored a bit in order to show the benchmark summary on GitHub action.I refactored the
nix
shell specification in order to speed up ci, and alsodisabled ci jobs running on self-host runner when pushed to fork repositories by the way.