Format: Ignore symlinks #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
format_symlink
branch
from
c5af04a to
7a9c9cd
Compare
mkannwischer
approved these changes
Jan 6, 2025
The examples in `examples/` contain many symlinks to the mlkem-native source files. Previously, `format`, and specifically `clang-format` invoked by it, would follow those symlinks and replace them by a copy of the modified file if the linked file needed re-formatting. This is not desirable: _only_ the file behind the symlink should be changed. This commit fixes `format` by not running `clang-format` on symlinks. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
format_symlink
branch
from
7a9c9cd to
ffcdb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatcreates copies from symlinks #614The examples in
examples/contain many symlinks to the mlkem-native source files. Previously,format, and specificallyclang-formatinvoked by it, would follow those symlinks and replace them by a copy of the modified file if the linked file needed re-formatting. This is not desirable: only the file behind the symlink should be changed.This commit fixes
formatby not runningclang-formaton symlinks.