Remove STATIC_TESTABLE and STATIC_INLINE_TESTABLE wrappers #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows overwriting `INLINE` through CFLAGS, which will be handy e.g. for the CBMC build where both `static` and `inline` should be ignored. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
no_static_testable
branch
from
f596e71 to
b848536
Compare
STATIC_TESTABLE and STATIC_INLINE_TESTABLE were previously used as wrappers around `static` and `static inline` that were defined as empty for a CBMC build, thereby lifting visibility of static (inline) functions so that CBMC would see them. This commit achieves the same without STATIC_TESTABLE and STATIC_INLINE_TESTABLE, both of which are removed, by defining `static` and `INLINE` as the empty string in a CBMC build. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
no_static_testable
branch
from
b848536 to
5ef85ed
Compare
mkannwischer
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATIC_TESTABLE and STATIC_INLINE_TESTABLE were previously used as wrappers
around
staticandstatic inlinethat were defined as empty for a CBMCbuild, thereby lifting visibility of static (inline) functions so that CBMC
would see them.
This commit achieves the same without STATIC_TESTABLE and
STATIC_INLINE_TESTABLE, both of which are removed, by defining
staticand
INLINEas the empty string in a CBMC build.